Skip to content

Conversation

notriddle
Copy link
Contributor

Related to #95601

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Apr 7, 2022
@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 7, 2022
@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@notriddle
Copy link
Contributor Author

notriddle commented Apr 10, 2022

@GuillaumeGomez it looks like bors didn’t hear you.

@notriddle
Copy link
Contributor Author

@bors r=GuillaumeGomez

@bors
Copy link
Collaborator

bors commented Apr 10, 2022

📌 Commit 898ff01 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2022
@bors
Copy link
Collaborator

bors commented Apr 10, 2022

⌛ Testing commit 898ff01 with merge 270a3e16d0227949c9f1912385c850e6086e5c38...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Apr 10, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 10, 2022
@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

Submitted a fixed version of this thing for Windows, which now produces very subtly different output.

@rust-log-analyzer

This comment has been minimized.

@notriddle notriddle force-pushed the notriddle/doctest-signal branch from f4970ac to daa903c Compare April 11, 2022 20:02
@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

📌 Commit 2af843c has been approved by GuillaumeGomez

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 12, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2022
Rollup of 4 pull requests

Successful merges:

 - rust-lang#95783 (rustdoc doctest: include signal number in exit status)
 - rust-lang#95794 (`parse_tt`: a few more tweaks)
 - rust-lang#95963 ([bootstrap] Grab the right FileCheck binary for dist when cross-compiling.)
 - rust-lang#95975 (Don't test -Cdefault-linker-libraries=yes when cross compiling.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7644de5 into rust-lang:master Apr 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 12, 2022
@notriddle notriddle deleted the notriddle/doctest-signal branch April 12, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants