Regression test for ICE. Fix #5153. #9515
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Is there a particular reason this is an error-pattern rather than a //~ ERROR line error?
Contributor
Author
There was a problem hiding this comment.
the error message was too long to go on the same line without going over 100 characters. I looked quickly at the other tests in that directory and many of them seemed to use error-pattern, e.g. bad-expr-path.rs
Contributor
There was a problem hiding this comment.
FWIW, you can put it on a later line with //~^ ERROR (the number of ^s corresponds to the number of lines above that the error should occur).
Contributor
Author
There was a problem hiding this comment.
ah, good to know, I'll try to do that in the future. not really worth blocking this PR though IMO.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Oct 6, 2022
…, r=Manishearth Don't lint unstable moves in `std_instead_of_core` Fixes rust-lang#9515 changelog: [`std_instead_of_core`]: No longer suggests unstable modules such as `core::error`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? anyone