Skip to content

Fix switch on discriminant detection in a presence of coverage counters #93870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2022
Merged

Fix switch on discriminant detection in a presence of coverage counters #93870

merged 1 commit into from
Feb 26, 2022

Conversation

tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Feb 10, 2022

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 10, 2022
@ecstatic-morse
Copy link
Contributor

@bors r+

Sorry @tmiasko, I lost track of this one. Frankly, I think if we're not going to have MIR-SSA, we should have a SwitchDiscriminant terminator to make this a first-class operation, but I don't have the energy to make that happen.

@bors
Copy link
Collaborator

bors commented Feb 25, 2022

📌 Commit 63bf601 has been approved by ecstatic-morse

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 25, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 25, 2022
@matthiaskrgr
Rollup merge of rust-lang#93870 - tmiasko:const-precise-live-drops-wi…
8b72adb 
…th-coverage, r=ecstatic-morse

Fix switch on discriminant detection in a presence of coverage counters

Fixes rust-lang#93848.

r? `@ecstatic-morse`
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 25, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 25, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2022
@bors
Auto merge of rust-lang#94385 - matthiaskrgr:rollup-4pwegqk, r=matthi…
12b71ed 
…askrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#93603 (Populate liveness facts when calling `get_body_with_borrowck_facts` without `-Z polonius`)
 - rust-lang#93870 (Fix switch on discriminant detection in a presence of coverage counters)
 - rust-lang#94355 (Add one more case to avoid ICE)
 - rust-lang#94363 (Remove needless borrows from core::fmt)
 - rust-lang#94377 (`check_used` should only look at actual `used` attributes)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0da6dd3 into rust-lang:master Feb 26, 2022
@rustbot rustbot added this to the 1.61.0 milestone Feb 26, 2022
@tmiasko tmiasko deleted the const-precise-live-drops-with-coverage branch February 26, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.61.0
Development

Successfully merging this pull request may close these issues.

core fails to build with E0493 when coverage instrumentation is enabled
4 participants
@tmiasko @ecstatic-morse @bors @rustbot