Skip to content

rustdoc: Remove the intra-doc links side channel #92601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jan 11, 2022
Merged

rustdoc: Remove the intra-doc links side channel #92601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f89e2dd
Move anchor conflict check to call site
camelid Jan 6, 2022
3b50a4e
Use `DefId`s instead of names in `UrlFragment`
camelid Jan 6, 2022
a324fc1
Only check for conflicting anchors in one place
camelid Jan 6, 2022
7e3132a
Extract function for reporting feature gate error
camelid Jan 6, 2022
1064003
Use fragment instead of side channel for prim. assoc. items
camelid Jan 6, 2022
fde9453
Use fragment instead of side channel in another place
camelid Jan 6, 2022
54a14e8
Remove the last use of the side channel
camelid Jan 6, 2022
a69e15c
Remove the side channel
camelid Jan 6, 2022
a626da4
Split out `ItemFragment` from `UrlFragment`
camelid Jan 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/librustdoc/clean/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
use std::cell::RefCell;
use std::default::Default;
use std::fmt::Write;
use std::hash::Hash;
use std::lazy::SyncOnceCell as OnceCell;
use std::path::PathBuf;
Expand Down Expand Up @@ -496,7 +495,7 @@ impl Item {
if let Ok((mut href, ..)) = href(*did, cx) {
debug!(?href);
if let Some(ref fragment) = *fragment {
write!(href, "{}", fragment).unwrap()
fragment.render(&mut href, cx.tcx()).unwrap()
}
Some(RenderedLink {
original_text: s.clone(),
Expand Down
Loading