Rustdoc: resolve associated traits for non-generic primitive types #92443

mdibaiee · 2021-12-30T17:09:40Z

This seems to work:

I'm just afraid I might have missed some cases / broken previous functionality.

I also have not written tests yet, I will have to take a look to see where tests are and how they are structured, but any help there is also appreciated.

rust-highfive · 2021-12-30T17:09:42Z

Some changes occurred in intra-doc-links.

cc @jyn514

rust-highfive · 2021-12-30T17:09:43Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon.

Please see the contribution instructions for more information.

src/librustdoc/passes/collect_intra_doc_links.rs

mdibaiee · 2021-12-30T17:52:18Z

The job x86_64-gnu-llvm-12 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

If I understand this correctly, we have tests that confirm that associated items on primitive types don't work, and because now they work as part of this PR, this test is failing. I suppose I can delete these tests and instead write tests for them working?

camelid · 2022-01-02T20:40:41Z

r? @Manishearth

src/test/rustdoc/intra-doc/prim-associated-traits.rs

src/librustdoc/passes/collect_intra_doc_links.rs

Manishearth · 2022-01-03T16:43:38Z

@bors r+

bors · 2022-01-03T16:43:39Z

📌 Commit 9146339a2d016db07d0461c8c5c0da6b5c19baec has been approved by Manishearth

camelid · 2022-01-05T05:22:32Z

Weird... I think those should have been run on CI.

mdibaiee · 2022-01-05T07:26:53Z

Weird indeed, I ran these tests locally and they passed. I’ll take a look now

mdibaiee · 2022-01-05T07:41:19Z

Okay I think I found the issue: I was using these XPATHs:

// @has 'prim_associated_traits/struct.Number.html' '//a[@href="https://doc.rust-lang.org/nightly/std/primitive.f64.html#method.from_str"]' 'f64::from_str()'

I just noticed all other tests in the same directory use {{channel}} instead of https://doc.rust-lang.org/nightly, so I changed it to:

// @has 'prim_associated_traits/struct.Number.html' '//a[@href="{{channel}}/std/primitive.f64.html#method.from_str"]' 'f64::from_str()'

The test that failed is stable and that's failing because I'm expecting nightly links. My bad.
~~Commit coming soon.~~

Latest push includes the fix.

Fixes rust-lang#90703

Manishearth · 2022-01-05T16:34:10Z

@bors r+

bors · 2022-01-05T16:34:12Z

📌 Commit 973cf63 has been approved by Manishearth

jyn514 · 2022-01-05T16:41:35Z

@pietroalbini your checks are paying off :)

…imitive-types, r=Manishearth Rustdoc: resolve associated traits for non-generic primitive types Fixes rust-lang#90703 This seems to work: <img width="457" alt="image" src="https://user-images.githubusercontent.com/2807772/147774059-9556ff96-4519-409e-8ed0-c33ecc436171.png"> I'm just afraid I might have missed some cases / broken previous functionality. I also have not written tests yet, I will have to take a look to see where tests are and how they are structured, but any help there is also appreciated.

…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#92058 (Make Run button visible on hover) - rust-lang#92288 (Fix a pair of mistyped test cases in `std::net::ip`) - rust-lang#92349 (Fix rustdoc::private_doc_tests lint for public re-exported items) - rust-lang#92360 (Some cleanups around check_argument_types) - rust-lang#92389 (Regression test for borrowck ICE rust-lang#92015) - rust-lang#92404 (Fix font size for [src] links in headers) - rust-lang#92443 (Rustdoc: resolve associated traits for non-generic primitive types) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned ollie27 Dec 30, 2021

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Dec 30, 2021

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from bf43a4f to 61bc754 Compare December 30, 2021 17:09

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 30, 2021

mdibaiee commented Dec 30, 2021

View reviewed changes

src/librustdoc/passes/collect_intra_doc_links.rs Outdated Show resolved Hide resolved

mdibaiee commented Dec 30, 2021

View reviewed changes

src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved

mdibaiee commented Dec 30, 2021

View reviewed changes

src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved

mdibaiee commented Dec 30, 2021

View reviewed changes

src/librustdoc/passes/collect_intra_doc_links.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

rust-highfive assigned Manishearth and unassigned ollie27 Jan 2, 2022

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from 4fc428e to 55543ae Compare January 2, 2022 21:27

This comment has been minimized.

Sign in to view

camelid reviewed Jan 2, 2022

View reviewed changes

src/test/rustdoc/intra-doc/prim-associated-traits.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from bdaa71b to a61b438 Compare January 3, 2022 07:05

This comment has been minimized.

Sign in to view

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch 2 times, most recently from 2760760 to 3183a79 Compare January 3, 2022 10:09

Manishearth approved these changes Jan 3, 2022

View reviewed changes

src/librustdoc/passes/collect_intra_doc_links.rs Outdated Show resolved Hide resolved

src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved

src/librustdoc/passes/collect_intra_doc_links.rs Show resolved Hide resolved

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 3, 2022

mdibaiee mentioned this pull request Jan 3, 2022

rustdoc: cannot resolve links to associated trait items for primitives #90703

Closed

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from 4ac9a3f to d0db13f Compare January 3, 2022 18:10

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 5, 2022

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from eb00e14 to c3785ae Compare January 5, 2022 07:32

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from c6dfca4 to c3c6f79 Compare January 5, 2022 07:58

mdibaiee added 3 commits January 5, 2022 08:03

Rustdoc: resolve associated traits for primitive types

83487b8

Fixes rust-lang#90703

add a test case for each supported primitive type

19419f3

Remove unsupported types in primitive_to_ty conversion, add FIXME note

973cf63

mdibaiee force-pushed the 90703/resolve-traits-of-primitive-types branch from c3c6f79 to 973cf63 Compare January 5, 2022 08:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 5, 2022

matthiaskrgr mentioned this pull request Jan 5, 2022

Rollup of 7 pull requests #92590

Closed

matthiaskrgr mentioned this pull request Jan 5, 2022

Rollup of 7 pull requests #92593

Closed

matthiaskrgr mentioned this pull request Jan 6, 2022

Rollup of 7 pull requests #92609

Merged

bors merged commit 26a90e4 into rust-lang:master Jan 6, 2022

rustbot added this to the 1.59.0 milestone Jan 6, 2022

mdibaiee deleted the 90703/resolve-traits-of-primitive-types branch January 6, 2022 18:51

camelid mentioned this pull request Jan 8, 2022

Rustdoc: regression in intra-doc link to trait function #92662

Closed

Rustdoc: resolve associated traits for non-generic primitive types #92443

Rustdoc: resolve associated traits for non-generic primitive types #92443

Uh oh!

Conversation

mdibaiee commented Dec 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-highfive commented Dec 30, 2021

Uh oh!

rust-highfive commented Dec 30, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

mdibaiee commented Dec 30, 2021

Uh oh!

camelid commented Jan 2, 2022

Uh oh!

This comment has been minimized.

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

Manishearth commented Jan 3, 2022

Uh oh!

bors commented Jan 3, 2022

Uh oh!

camelid commented Jan 5, 2022

Uh oh!

mdibaiee commented Jan 5, 2022

Uh oh!

mdibaiee commented Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Manishearth commented Jan 5, 2022

Uh oh!

bors commented Jan 5, 2022

Uh oh!

jyn514 commented Jan 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

mdibaiee commented Dec 30, 2021 •

edited

Loading

mdibaiee commented Jan 5, 2022 •

edited

Loading

jyn514 commented Jan 5, 2022 •

edited

Loading