Improve std::iter::zip example
#91711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
andrewbanchich
changed the title
std::iter::zip example
ghost
reviewed
Dec 9, 2021
|
Mind squashing the commits into one? r=me with that done. |
Update library/core/src/iter/adapters/zip.rs Co-authored-by: r00ster <[email protected]> Update library/core/src/iter/adapters/zip.rs Co-authored-by: r00ster <[email protected]>
|
(not sure if I did that right since I'm not sure what r=me does and Google doesn't help) |
|
@andrewbanchich: 🔑 Insufficient privileges: Not in reviewers |
|
Just means that I'll be happy to approve the PR with that change. @bors r+ |
|
📌 Commit c78fb62 has been approved by |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 11, 2021
… r=Mark-Simulacrum Improve `std::iter::zip` example `println!` isn't great for doc comments / tests.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 11, 2021
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#91617 (Improve the readability of `List<T>`.) - rust-lang#91640 (Simplify collection of in-band lifetimes) - rust-lang#91682 (rustdoc: Show type layout for type aliases) - rust-lang#91711 (Improve `std::iter::zip` example) - rust-lang#91717 (Add deprecation warning for --passes) - rust-lang#91718 (give more help in the unaligned_references lint) - rust-lang#91782 (Correct since attribute for `is_symlink` feature) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
println!isn't great for doc comments / tests.