Add readable rustdoc display for RISC-V target #91518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ollie27 (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
luojia65
force-pushed
the
rustdoc-riscv-arch
branch
from
909383b to
4d457de
Compare
apiraino
added
the
T-rustdoc
JohnCSimon
added
S-waiting-on-review
use format 'RISC-V RV32' and 'RISC-V RV64'
luojia65
force-pushed
the
rustdoc-riscv-arch
branch
from
4d457de to
39d99a1
Compare
|
Edit: after discussions with TUNA members the format used here are 'RISC-V RV32' and 'RISC-V RV64'. Now this pull request may be ready for review. r? @ollie27 |
|
The idea of this change seems good to me, but I think the names should be |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
|
Any update on this @luojia65 ? |
GuillaumeGomez
added
S-waiting-on-author
|
@GuillaumeGomez It's okay for me, no further updates :) |
|
Well, we can always update the text later on. Thanks! @bors: r+ rollup |
|
📌 Commit 39d99a1 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 11, 2022
Rollup of 4 pull requests Successful merges: - rust-lang#91518 (Add readable rustdoc display for RISC-V target) - rust-lang#95281 (Fix inaccurate function name in `rustc_const_eval` docs) - rust-lang#96898 (logging: add env var to control verbose scope entry/exit logging) - rust-lang#96936 (:arrow_up: rust-analyzer) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a human readable rustdoc display for RISC-V architecture. Target configuration marked as
#[cfg(target_arch = "riscv32")]or#[cfg(target_arch = "riscv64")]are pretty formatted likeRISC-V RV32andRISC-V RV64in Rust docs.Before:
After: