Rollup of 3 pull requests #91320
Merged
Rollup of 3 pull requests #91320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the ICE in rust-lang#88586.
…asper Perform Sync check on static items in wf-check instead of during const checks r? `@RalfJung` This check is solely happening on the signature of the static item and not on its body, therefor it belongs into wf-checking instead of const checking.
Fix ICE when lowering `trait A where for<'a> Self: 'a` Fixes rust-lang#88586. r? `@jackh726` Jack, this fix is much smaller in scope than what I think you were proposing in the issue. Let me know if you had a vision for a larger refactor here. cc `@JohnTitor`
Change output path to {{build-base}} for rustdoc scrape_examples ui test
See rust-lang#90611 (comment)
r? `@jyn514`
cc `@petrochenkov`
Member
Author
|
@bors r+ rollup=never p=3 |
Collaborator
|
📌 Commit a7639b6 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
2 tasks
Collaborator
|
Finished benchmarking commit (db9d361): comparison url. Summary: This change led to large relevant improvements 🎉 in compiler performance.
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
trait A where for<'a> Self: 'a#91308 (Fix ICE when loweringtrait A where for<'a> Self: 'a)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup