Skip to content

Conversation

RalfJung
Copy link
Member

#85376 introduced a regression in Miri, reported at rust-lang/miri#1919 and rust-lang/miri#1925. This PR fixes that. I will add tests to Miri once this lands.

r? @oli-obk
Fixes rust-lang/miri#1919
Fixes rust-lang/miri#1925

@rust-highfive
Copy link
Contributor

Some changes occured to the CTFE / Miri engine

cc @rust-lang/miri

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 27, 2021
@camelid camelid added A-miri Area: The miri tool T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 27, 2021
@oli-obk
Copy link
Contributor

oli-obk commented Nov 28, 2021

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 28, 2021

📌 Commit f8e3b31 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 28, 2021
…askrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#90896 (Stabilize some `MaybeUninit` behavior as const)
 - rust-lang#91254 (Only check for errors in predicate when skipping impl assembly)
 - rust-lang#91303 (Miri: fix alignment check in array initialization)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7134ae0 into rust-lang:master Nov 28, 2021
@rustbot rustbot added this to the 1.59.0 milestone Nov 28, 2021
@RalfJung RalfJung deleted the array-init-align branch November 28, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False Positive - incorrect alignment Unaligned error with async generator field
6 participants