Skip to content

Conversation

ast-ral
Copy link
Contributor

@ast-ral ast-ral commented Oct 12, 2021

Fixes minor spelling error in the proposed Poll::ready docs. Not that my opinion matters, but +1 on the original PR (#89651), it reads much nicer to me than the ready! macro.

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2021
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Oct 12, 2021

📌 Commit 5100630 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 12, 2021
…htriplett

fix minor spelling error in Poll::ready docs

Fixes minor spelling error in the proposed `Poll::ready` docs. Not that my opinion matters, but +1 on the original PR (rust-lang#89651), it reads much nicer to me than the `ready!` macro.
the8472 added a commit to the8472/rust that referenced this pull request Oct 12, 2021
…htriplett

fix minor spelling error in Poll::ready docs

Fixes minor spelling error in the proposed `Poll::ready` docs. Not that my opinion matters, but +1 on the original PR (rust-lang#89651), it reads much nicer to me than the `ready!` macro.
This was referenced Oct 12, 2021
@ibraheemdev
Copy link
Member

Oops, thanks for catching this :)

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2021
Rollup of 7 pull requests

Successful merges:

 - rust-lang#89778 (Add #[must_use] to as_type conversions)
 - rust-lang#89784 (Remove built-in query cache_hit tracking)
 - rust-lang#89796 (Add #[must_use] to non-mutating verb methods)
 - rust-lang#89797 (Add #[must_use] to is_condition tests)
 - rust-lang#89799 (fix minor spelling error in Poll::ready docs)
 - rust-lang#89800 (Update books)
 - rust-lang#89809 (Remap ssa RealPredicate to llvm RealPredicate)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7017410 into rust-lang:master Oct 12, 2021
@rustbot rustbot added this to the 1.57.0 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants