Optimize is_sorted for Range and RangeInclusive #89335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Step` trait guarantees that `Range<impl Step>` yields items in sorted order. We can override the `Iterator::is_sorted` method based on this guarantee, as we already do for `Iterator::min` and `max`.
|
r? @scottmcm (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
mbrubeck
added
A-iterators
|
📌 Commit 830ecbd has been approved by |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 29, 2021
Optimize is_sorted for Range and RangeInclusive The [`Step`] trait guarantees that `Range<impl Step>` yields items in sorted order. We can override `Iterator::is_sorted` based on this guarantee, as we already do for `Iterator::min` and `max`. Thank you to `@fiveseven-lambda` who pointed this out [on the Rust Users Forum](https://users.rust-lang.org/t/is-sorted-method-in-impl-iterator-for-range/64717). [`Step`]: https://doc.rust-lang.org/stable/std/iter/trait.Step.html
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 30, 2021
Rollup of 13 pull requests Successful merges: - rust-lang#87428 (Fix union keyword highlighting in rustdoc HTML sources) - rust-lang#88412 (Remove ignore-tidy-undocumented-unsafe from core::slice::sort) - rust-lang#89098 (Fix generics where bounds order) - rust-lang#89232 (Improve help for recursion limit errors) - rust-lang#89294 (:arrow_up: rust-analyzer) - rust-lang#89297 (Remove Never variant from clean::Type enum) - rust-lang#89311 (Add unit assignment to MIR for `asm!()`) - rust-lang#89313 (PassWrapper: handle function rename from upstream D36850) - rust-lang#89315 (Clarify that `CString::from_vec_unchecked` appends 0 byte.) - rust-lang#89335 (Optimize is_sorted for Range and RangeInclusive) - rust-lang#89366 (rustdoc: Remove lazy_static dependency) - rust-lang#89377 (Update cargo) - rust-lang#89378 (Update books) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Steptrait guarantees thatRange<impl Step>yields items in sorted order. We can overrideIterator::is_sortedbased on this guarantee, as we already do forIterator::minandmax.Thank you to @fiveseven-lambda who pointed this out on the Rust Users Forum.