Refactor unsized suggestions #86454
Merged
Refactor unsized suggestions #86454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-diagnostics
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I'm not the right reviewer for this. Maybe r? @estebank |
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
JohnCSimon
added
S-waiting-on-review
|
triage: r? @davidtwco (feel free to reassign) |
|
@bors r+ |
|
📌 Commit 3252432 has been approved by |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 16, 2021
…unsized, r=estebank check where-clause for explicit `Sized` before suggesting `?Sized` Fixes rust-lang#85945. Based on rust-lang#86454. `@rustbot` label +A-diagnostics +A-traits +A-typesystem +D-papercut +T-compiler
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 16, 2021
…unsized, r=estebank check where-clause for explicit `Sized` before suggesting `?Sized` Fixes rust-lang#85945. Based on rust-lang#86454. ``@rustbot`` label +A-diagnostics +A-traits +A-typesystem +D-papercut +T-compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rustbot label +A-diagnostics +A-traits +A-typesystem +C-cleanup +T-compiler