Skip to content

don't clone attrs #86043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2021
Merged

don't clone attrs #86043

merged 1 commit into from
Jun 6, 2021

Conversation

klensy
Copy link
Contributor

@klensy klensy commented Jun 5, 2021

No description provided.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 5, 2021

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 5, 2021
@bors
Copy link
Collaborator

bors commented Jun 5, 2021

⌛ Trying commit 56a2a2a with merge 951df56d7e55a519362d18ac980416c51d1ac44d...

@jyn514 jyn514 added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-parser Area: The lexing & parsing of Rust source code to an AST labels Jun 5, 2021
@bors
Copy link
Collaborator

bors commented Jun 5, 2021

☀️ Try build successful - checks-actions
Build commit: 951df56d7e55a519362d18ac980416c51d1ac44d (951df56d7e55a519362d18ac980416c51d1ac44d)

@rust-timer
Copy link
Collaborator

Queued 951df56d7e55a519362d18ac980416c51d1ac44d with parent ac3e680, future comparison URL.

@petrochenkov petrochenkov removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (951df56d7e55a519362d18ac980416c51d1ac44d): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 6, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 6, 2021

Perf looks like noise, but this is a nice cleanup anyway.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 6, 2021

📌 Commit 56a2a2a has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2021
@JohnTitor JohnTitor mentioned this pull request Jun 6, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2021
@bors
Auto merge of rust-lang#86054 - JohnTitor:rollup-j40z7sm, r=JohnTitor
f57d5ba 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#85436 (Avoid cloning cache key)
 - rust-lang#85772 (Preserve metadata w/ Solaris-like linkers.)
 - rust-lang#85920 (Tweak wasm_base target spec to indicate linker is not GNU and update linker inferring logic for wasm-ld.)
 - rust-lang#85930 (Update standard library for IntoIterator implementation of arrays )
 - rust-lang#85972 (Rustdoc html fixes)
 - rust-lang#86028 (Drop an `if let` that will always succeed)
 - rust-lang#86043 (don't clone attrs)
 - rust-lang#86047 (Don't fire `invalid_doc_attributes` on `extern crate` items)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2f0a855 into rust-lang:master Jun 6, 2021
@rustbot rustbot added this to the 1.54.0 milestone Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-parser Area: The lexing & parsing of Rust source code to an AST S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.54.0
Development

Successfully merging this pull request may close these issues.
7 participants
@klensy @rust-highfive @jyn514 @rust-timer @bors @petrochenkov @rustbot