Skip to content

Conversation

GuillaumeGomez
Copy link
Member

This is something that @Nemo157 was talking about: they wanted that when using x.py doc std, it only generated std (and the crates "before" it).

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 11, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the generate-not-more-docs-than-necessary branch from 287ec42 to a62af89 Compare May 11, 2021 13:57
@rust-lang rust-lang deleted a comment from rust-highfive May 11, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the generate-not-more-docs-than-necessary branch 2 times, most recently from b50181b to a62af89 Compare May 11, 2021 15:20
@camelid camelid added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 11, 2021
@Mark-Simulacrum
Copy link
Member

You will need to modify the mingw-check builder to continue documenting the full set of crates after this change, by updating this line to pass library/test. r=me with that done; please make it part of the same commit.

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 14, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the generate-not-more-docs-than-necessary branch from a62af89 to b9b67b7 Compare May 15, 2021 15:21
@GuillaumeGomez
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented May 15, 2021

📌 Commit b9b67b7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 15, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request May 15, 2021
…laumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#84751 (str::is_char_boundary - slight optimization)
 - rust-lang#85185 (Generate not more docs than necessary)
 - rust-lang#85324 (Warn about unused `pub` fields in non-`pub` structs)
 - rust-lang#85329 (fix version_str comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f851f97 into rust-lang:master May 15, 2021
@rustbot rustbot added this to the 1.54.0 milestone May 15, 2021
@GuillaumeGomez GuillaumeGomez deleted the generate-not-more-docs-than-necessary branch May 15, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants