Skip to content

Disable using non-ascii identifiers in extern blocks. #83936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

Disable using non-ascii identifiers in extern blocks. #83936

merged 1 commit into from
Apr 7, 2021

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Apr 6, 2021

Fixes #83923.

@rust-highfive
Copy link
Contributor

r? @petrochenkov

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 6, 2021
This was referenced Apr 6, 2021
Closed
Closed
@crlf0710 crlf0710 added the F-non_ascii_idents `#![feature(non_ascii_idents)]` label Apr 6, 2021
Manishearth
Manishearth approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, but should we file a followup for enabling this and link to it in the error?

@crlf0710 crlf0710 force-pushed the disallow_extern_block_non_ascii branch from 075540d to e5babe4 Compare April 6, 2021 16:01
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@crlf0710 crlf0710 force-pushed the disallow_extern_block_non_ascii branch from e5babe4 to 39974f1 Compare April 6, 2021 16:41
@Dylan-DPC-zz
Copy link

@bors r=manishearth rollup

@bors
Copy link
Collaborator

bors commented Apr 6, 2021

📌 Commit 39974f1d525801b9a98eead14a61b6774b348b23 has been approved by manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2021
@Manishearth
Copy link
Member

@bors r-

@Dylan-DPC I was r+ with a caveat

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 6, 2021
@petrochenkov
Copy link
Contributor

r? @Manishearth

Manishearth
Manishearth reviewed Apr 6, 2021
View reviewed changes
@crlf0710 crlf0710 force-pushed the disallow_extern_block_non_ascii branch from 39974f1 to 4752a54 Compare April 7, 2021 01:57
@crlf0710
Copy link
Member Author

crlf0710 commented Apr 7, 2021

Updated and added the link. @Manishearth

@Manishearth
Copy link
Member

@bors r+ rollup

thanks!

@bors
Copy link
Collaborator

bors commented Apr 7, 2021

📌 Commit 4752a54 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 7, 2021
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 7, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 7, 2021
@bors
Auto merge of rust-lang#83964 - Dylan-DPC:rollup-9kinaiv, r=Dylan-DPC
e9cdccc 
Rollup of 8 pull requests

Successful merges:

 - rust-lang#83476 (Add strong_count mutation methods to Rc)
 - rust-lang#83634 (Do not emit the advanced diagnostics on macros)
 - rust-lang#83816 (Trigger `unused_doc_comments` on macros at once)
 - rust-lang#83916 (Use AnonConst for asm! constants)
 - rust-lang#83935 (forbid `impl Trait` in generic param defaults)
 - rust-lang#83936 (Disable using non-ascii identifiers in extern blocks.)
 - rust-lang#83945 (Add suggestion to reborrow mutable references when they're moved in a for loop)
 - rust-lang#83954 (Do not ICE when closure is involved in Trait Alias Impl Trait)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9c688cd into rust-lang:master Apr 7, 2021
@rustbot rustbot added this to the 1.53.0 milestone Apr 7, 2021
@crlf0710 crlf0710 deleted the disallow_extern_block_non_ascii branch April 7, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees

@Manishearth Manishearth

Labels
F-non_ascii_idents `#![feature(non_ascii_idents)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.53.0
Development

Successfully merging this pull request may close these issues.

Non-ASCII identifiers should be restricted within extern blocks.
8 participants
@crlf0710 @rust-highfive @rust-log-analyzer @Dylan-DPC-zz @bors @Manishearth @petrochenkov @rustbot