FALSE is not 1u8 but 0u8, of cource. #8137
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: OGINO Masanori <[email protected]>
|
my goodness :P |
|
Why do we have these |
bors
added a commit
that referenced
this pull request
Jul 30, 2013
Obvious mistake, but there is no failure because no code uses FALSE.
|
@thestinger looks like it's for comparing against the output of C functions? |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 30, 2021
Fix commits and formatting of CHANGELOG.md r? `@Manishearth` Follow up to rust-lang#8136 I think the beta commit update didn't take the backport we've done into account. I fixed the commit ranges. And while I was at it, I also applied my usual formatting to the changelog entries. changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Obvious mistake, but there is no failure because no code uses FALSE.