[beta] Clippy backport field_reassign_with_default fix #80680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default value for a field type does not necessarily match the default value for that field in the struct Default.
There is already an assertion that consecutive lines assign to a struct field.
[beta] Backport of rust-lang#6375 - field_reassign_with_default fix With the pinned nightly we can test backports to our beta branch now 🎉 cc rust-lang#6515 changelog: beta 1.50: Backport of private fields fix in [`field_reassign_with_default`] lints
|
rust-highfive
added
the
S-waiting-on-review
Manishearth
approved these changes
Jan 4, 2021
|
@bors r+ rollup=never |
|
📌 Commit 70fced0 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 70fced0 with merge bba12f48abb6c4352bae61af61fa744d27f28aa3... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
seems spurious? |
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 70fced0 with merge 747421926aa9b172d5fa5c69319b6dc90b356454... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry Can't find any online and idle self-hosted runner in current repository that matches the required labels: 'ubuntu-latest' |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @ebroto @Manishearth
We had multiple complaints about this lint landing in stable 1.49 with a FP hit quite often in real world code. We want to backport the fix for this, so it already gets into 1.50. A stable backport is not warranted by this IMO.
r? @Mark-Simulacrum