Skip to content

Conversation

poliorcetics
Copy link
Contributor

Fix #80015

@rustbot label C-cleanup T-rustdoc A-markdown-parsing

@rustbot rustbot added A-markdown-parsing Area: Markdown parsing for doc-comments C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 19, 2020
@rust-highfive
Copy link
Contributor

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 19, 2020
@poliorcetics poliorcetics force-pushed the rustdoc-default-langstring branch from 066e528 to 74bd2ea Compare December 19, 2020 23:26
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass.

@jyn514
Copy link
Member

jyn514 commented Dec 20, 2020

@bors r=GuillaumeGomez,jyn514 rollup

@bors
Copy link
Collaborator

bors commented Dec 20, 2020

📌 Commit 74bd2ea has been approved by GuillaumeGomez,jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 20, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 20, 2020
…ring, r=GuillaumeGomez,jyn514

impl Default for LangString, replacing all_false by default

Fix rust-lang#80015

`@rustbot` label C-cleanup  T-rustdoc  A-markdown-parsing
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Dec 20, 2020
…ring, r=GuillaumeGomez,jyn514

impl Default for LangString, replacing all_false by default

Fix rust-lang#80015

``@rustbot`` label C-cleanup  T-rustdoc  A-markdown-parsing
@bors
Copy link
Collaborator

bors commented Dec 21, 2020

⌛ Testing commit 74bd2ea with merge 463ce40...

@bors
Copy link
Collaborator

bors commented Dec 21, 2020

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez,jyn514
Pushing 463ce40 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 21, 2020
@bors bors merged commit 463ce40 into rust-lang:master Dec 21, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 21, 2020
@poliorcetics poliorcetics deleted the rustdoc-default-langstring branch December 21, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-markdown-parsing Area: Markdown parsing for doc-comments C-cleanup Category: PRs that clean code up or issues documenting cleanup. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename LangString::all_false() to default()
6 participants