Skip to content

Fix building compiler docs with stage 0 #79954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2020
Merged

Fix building compiler docs with stage 0 #79954

merged 1 commit into from
Dec 13, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 12, 2020

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 12, 2020
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2020
camelid
camelid reviewed Dec 12, 2020
View reviewed changes
@jyn514
Copy link
Member Author

jyn514 commented Dec 12, 2020

Err, this didn't completely work:

thread 'rustc' panicked at 'Unable to resolve external crate proc_macro2', src/librustdoc/core.rs:457:37
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: internal compiler error: unexpected panic
error: Unrecognized option: 'crate-version'
error: could not document `coverage_test_macros`

I'm not sure if this is a rustdoc bug or a bootstrap bug :/ doc --stage 1 works fine and the panic comes from

rust/src/librustdoc/core.rs

Line 448 in c3ed668

panic!("Unable to resolve external crate {}", extern_name)
which I haven't seen to fail before.

@Nadrieril Nadrieril mentioned this pull request Dec 12, 2020
Closed
@Mark-Simulacrum
Copy link
Member

@bors r+

This fix seems correct in the meantime.

@bors
Copy link
Collaborator

bors commented Dec 12, 2020

📌 Commit 9df0348 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2020
@JohnTitor JohnTitor mentioned this pull request Dec 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2020
@bors
Auto merge of rust-lang#79994 - JohnTitor:rollup-43wl2uj, r=JohnTitor
1281315 
Rollup of 12 pull requests

Successful merges:

 - rust-lang#79360 (std::iter: document iteration over `&T` and `&mut T`)
 - rust-lang#79398 (Link loop/for keyword)
 - rust-lang#79834 (Remove deprecated linked_list_extras methods.)
 - rust-lang#79845 (Fix rustup support in default_build_triple for python3)
 - rust-lang#79940 (fix more clippy::complexity findings)
 - rust-lang#79942 (Add post-init hook for static memory for miri.)
 - rust-lang#79954 (Fix building compiler docs with stage 0)
 - rust-lang#79963 (Fix typo in `DebruijnIndex` documentation)
 - rust-lang#79970 (Misc rustbuild improvements when the LLVM backend isn't used)
 - rust-lang#79973 (rustdoc light theme: Fix CSS for selected buttons)
 - rust-lang#79984 (Remove an unused dependency that made `rustdoc` crash)
 - rust-lang#79985 (Fixes submit event of the search input)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54119d4 into rust-lang:master Dec 13, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 13, 2020
@jyn514 jyn514 deleted the normalize-oops branch December 13, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camelid camelid camelid left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.50.0

Development

Successfully merging this pull request may close these issues.

6 participants

@jyn514 @Mark-Simulacrum @bors @camelid @rust-highfive @rustbot