Skip to content

Clean up docs for 'as' keyword #78093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2020
Merged

Clean up docs for 'as' keyword #78093

merged 1 commit into from
Nov 5, 2020

Conversation

camelid
Copy link
Member

@camelid camelid commented Oct 19, 2020

No description provided.

@camelid camelid added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Oct 19, 2020
@rust-highfive
Copy link
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 19, 2020
camelid
camelid commented Oct 19, 2020
View reviewed changes
This was referenced Oct 19, 2020
Closed
Closed
camelid
camelid commented Oct 19, 2020
View reviewed changes
@camelid
Copy link
Member Author

camelid commented Oct 23, 2020 •
edited
Loading

Re-running checks since CI seems to have failed for a different reason:

Could not get the latest source version for repository rust-lang/rust hosted on https://github.com/ using ref ffd4190395fd2d58005ac8dbf4d4e13baf01db5a. GitHub reported the error, "Internal Server Error"

@camelid
Copy link
Member Author

camelid commented Oct 23, 2020

Actually, that won't fix the try build which is the one that failed, thus cancelling so I don't waste CI time.

@camelid
Copy link
Member Author

camelid commented Oct 27, 2020

Rebased so that CI will be re-run and thus get rid of the spurious failure.

@camelid
Copy link
Member Author

camelid commented Nov 4, 2020

r? @jyn514

@rust-highfive rust-highfive assigned jyn514 and unassigned sfackler Nov 4, 2020
@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 4, 2020
@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 5, 2020
camelid
camelid commented Nov 5, 2020
View reviewed changes
@jyn514
Copy link
Member

jyn514 commented Nov 5, 2020

r=me with CI passing

@jyn514
Copy link
Member

jyn514 commented Nov 5, 2020

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 5, 2020

📌 Commit d8afe98 has been approved by jyn514

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2020
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 5, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 5, 2020
@JohnTitor
Rollup merge of rust-lang#78093 - camelid:as-cleanup, r=jyn514
d44e165 
Clean up docs for 'as' keyword
@JohnTitor JohnTitor mentioned this pull request Nov 5, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 5, 2020
@JohnTitor
Rollup merge of rust-lang#78093 - camelid:as-cleanup, r=jyn514
ab66a6a 
Clean up docs for 'as' keyword
@JohnTitor JohnTitor mentioned this pull request Nov 5, 2020
Closed
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 5, 2020
@m-ou-se
Rollup merge of rust-lang#78093 - camelid:as-cleanup, r=jyn514
c25ac7e 
Clean up docs for 'as' keyword
This was referenced Nov 5, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 5, 2020
@bors
Auto merge of rust-lang#78767 - m-ou-se:rollup-eu5wgxl, r=m-ou-se
f7801d6 
Rollup of 15 pull requests

Successful merges:

 - rust-lang#76718 (Move Vec UI tests to unit tests when possible)
 - rust-lang#78093 (Clean up docs for 'as' keyword)
 - rust-lang#78425 (Move f64::NAN ui tests into `library`)
 - rust-lang#78465 (Change as_str → to_string in proc_macro::Ident::span() docs)
 - rust-lang#78584 (Add keyboard handling to the theme picker menu)
 - rust-lang#78716 (Array trait impl comment/doc fixes)
 - rust-lang#78727 ((rustdoc) fix test for trait impl display)
 - rust-lang#78733 (fix a couple of clippy warnings:)
 - rust-lang#78735 (Simplify the implementation of `get_mut` (no unsafe))
 - rust-lang#78738 (Move range in ui test to ops test in library/core)
 - rust-lang#78739 (Fix ICE on type error in async function)
 - rust-lang#78742 (make intern_const_alloc_recursive return error)
 - rust-lang#78756 (Update cargo)
 - rust-lang#78757 (Improve and clean up some intra-doc links)
 - rust-lang#78758 (Fixed typo in comment)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 10d2843 into rust-lang:master Nov 5, 2020
@rustbot rustbot added this to the 1.49.0 milestone Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jyn514 jyn514 jyn514 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jyn514 jyn514

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.
6 participants
@camelid @rust-highfive @jyn514 @bors @sfackler @rustbot