Remove arena's dependency on rustc_data_structures
#77962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Maybe |
|
I am somewhat surprised to see it like this rather than an unlikely branch or whatever, but seems fine to do this. @bors r+ rollup=never in case of perf effects |
|
📌 Commit 52ff31a has been approved by |
bors
added
S-waiting-on-bors
|
This can have perf effects? 👀 |
jyn514
added
C-cleanup
|
☀️ Test successful - checks-actions, checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Oct 16, 2020
Tested on commit rust-lang/rust@8e6f69a. Direct link to PR: <rust-lang/rust#77962> 🎉 rls on windows: test-fail → test-pass (cc @Xanewok).
|
Umm, I'm quite sure this PR didn't fix rls? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustc_arenacurrently has a dependency onrustc_data_structuresbecause of a trivial "don't inline me" function. This PR copies that function and removes the dependency.