Refactor byteorder to std in rustc_middle #75741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
workingjubilee
force-pushed
the
refactor-byteorder
branch
3 times, most recently
from
09f6b30 to
3f4e682
Compare
tesuji
reviewed
Aug 20, 2020
workingjubilee
force-pushed
the
refactor-byteorder
branch
from
3f4e682 to
bd474e1
Compare
matklad
reviewed
Aug 20, 2020
workingjubilee
force-pushed
the
refactor-byteorder
branch
2 times, most recently
from
0f08382 to
cb4673d
Compare
crlf0710
reviewed
Aug 21, 2020
crlf0710
reviewed
Aug 21, 2020
|
☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts. |
workingjubilee
force-pushed
the
refactor-byteorder
branch
2 times, most recently
from
2f7654e to
b688314
Compare
|
@bors r+ |
|
📌 Commit b688314 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 4, 2020
…r=matthewjasper
Refactor byteorder to std in rustc_middle
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
|
☔ The latest upstream changes (presumably #75173) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
Co-authored-by: Aleksey Kladov <[email protected]>
Co-authored-by: matthewjasper <[email protected]>
workingjubilee
force-pushed
the
refactor-byteorder
branch
from
698541f to
2df552b
Compare
|
@workingjubilee: 🔑 Insufficient privileges: Not in reviewers |
rustbot
added
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 2df552b has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Sep 5, 2020
…r=matthewjasper
Refactor byteorder to std in rustc_middle
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.
This was referenced Sep 5, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 5, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#75695 (Add a regression test for issue-72793) - rust-lang#75741 (Refactor byteorder to std in rustc_middle) - rust-lang#75954 (Unstable Book: add links to tracking issues for FFI features) - rust-lang#75994 (`impl Rc::new_cyclic`) - rust-lang#76060 (Link vec doc to & reference) - rust-lang#76078 (Remove disambiguators from intra doc link text) - rust-lang#76082 (Fix intra-doc links on pub re-exports) - rust-lang#76254 (Fold length constant in Rvalue::Repeat) - rust-lang#76258 (x.py check checks tests/examples/benches) - rust-lang#76263 (inliner: Check for codegen fn attributes compatibility) - rust-lang#76285 (Move jointness censoring to proc_macro) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use std::io::{Read, Write} and {to, from}_{le, be}_bytes methods in
order to remove byteorder from librustc_middle's dependency graph.