Skip to content

Conversation

camelid
Copy link
Member

@camelid camelid commented Aug 9, 2020

Fixes #75245.


  • Rename it in the UI
  • Rename the CSS classes

@rust-highfive
Copy link
Contributor

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS themes.

cc @GuillaumeGomez

A change occurred in the Ayu theme.

cc @Cldfire

@rust-highfive
Copy link
Contributor

r? @ollie27

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2020
@camelid
Copy link
Member Author

camelid commented Aug 9, 2020

r? @Manishearth

@rust-highfive rust-highfive assigned Manishearth and unassigned ollie27 Aug 9, 2020
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 9, 2020
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the JS format changes.

@camelid
Copy link
Member Author

camelid commented Aug 9, 2020

@GuillaumeGomez Oops, thanks for catching that! VS Code must have done it...

@GuillaumeGomez
Copy link
Member

Don't worry, it's just very complicated to see the actual changes in the middle of all the formattings. ;)

* Rename it in the UI
* Rename the CSS classes
@camelid camelid force-pushed the rename-important-to-notable-traits branch from e5780f3 to f3cc957 Compare August 9, 2020 19:10
@camelid
Copy link
Member Author

camelid commented Aug 9, 2020

Fixed :)

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 9, 2020

📌 Commit f3cc957 has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 9, 2020
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@GuillaumeGomez
Copy link
Member

@bors: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 10, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#74200 (Std panicking unsafe block in unsafe fn)
 - rust-lang#75286 (Add additional case for Path starts with)
 - rust-lang#75318 (Resolve `char` as a primitive even if there is a module in scope)
 - rust-lang#75320 (Detect likely `for foo of bar` JS syntax)
 - rust-lang#75328 (Cleanup E0749)
 - rust-lang#75344 (Rename "Important traits" to "Notable traits")
 - rust-lang#75348 (Move to intra-doc links in library/core/src/time.rs)
 - rust-lang#75350 (Do not ICE when lowering invalid extern fn with bodies)

Failed merges:

r? @ghost
@bors bors merged commit 8176240 into rust-lang:master Aug 10, 2020
@camelid camelid deleted the rename-important-to-notable-traits branch August 10, 2020 02:36
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "important traits" to something better
8 participants