Add a bunch of const-generic revisions for `min_const_generics` #75322

JulianKnodt · 2020-08-09T05:03:17Z

This adds a bunch of revisions to const-generic tests which is part of #75279, but doesn't cover everything.

r? @lcnr

src/test/ui/const-generics/uninferred-consts.rs

src/test/ui/const-generics/unknown_adt.rs

lcnr

thanks 👍

Rn there are a lot of stale testname.stderr files (as we now have testname.full.stderr and testname.min.stderr).

It's probably easiest to delete all stderr files in src/test/ui/const-generics and then rerun the tests

src/test/ui/const-generics/array-size-in-generic-struct-param.rs

src/test/ui/const-generics/condition-in-trait-const-arg.rs

src/test/ui/const-generics/const-arg-in-fn.rs

src/test/ui/const-generics/const-argument-non-static-lifetime.rs

src/test/ui/const-generics/const-fn-with-const-param.rs

src/test/ui/const-generics/different_byref.rs

src/test/ui/const-generics/integer-literal-generic-arg-in-where-clause.rs

src/test/ui/const-generics/raw-ptr-const-param-deref.rs

src/test/ui/const-generics/slice-const-param-mismatch.rs

src/test/ui/const-generics/condition-in-trait-const-arg.rs

bors · 2020-08-11T02:05:01Z

☔ The latest upstream changes (presumably #74005) made this pull request unmergeable. Please resolve the merge conflicts.

lcnr · 2020-08-11T05:25:43Z

@bors r+ rollup=iffy

affects nearly all tests in src/test/ui/const-generics.

bors · 2020-08-11T05:26:02Z

📌 Commit ca6e996fc61c36f37381fca9a386d2ec1b740630 has been approved by lcnr

bors · 2020-08-11T06:00:42Z

⌛ Testing commit ca6e996fc61c36f37381fca9a386d2ec1b740630 with merge 898cd8acf6d8d354451bebd4cf7d07079076a033...

bors · 2020-08-11T06:12:30Z

💔 Test failed - checks-azure

lcnr · 2020-08-11T06:55:51Z

network

@bors retry

bors · 2020-08-11T08:16:45Z

⌛ Testing commit ca6e996fc61c36f37381fca9a386d2ec1b740630 with merge 098a5b6ba72225e0551a197d7478c9e1fb8c4313...

lcnr · 2020-08-11T12:46:49Z

seems like bors has some problems again 🤔 cc @rust-lang/infra

@bors retry

bors · 2020-08-11T17:32:42Z

⌛ Testing commit ca6e996fc61c36f37381fca9a386d2ec1b740630 with merge 0a410faa22b14680989543721516a350f3f58aec...

bors · 2020-08-11T17:51:35Z

💔 Test failed - checks-actions

lcnr · 2020-08-11T18:03:46Z

that one is actually legit.

@JulianKnodt seems like you have to rebase and rerun the test suite because of #75359

This adds a bunch of revisions to const-generic tests

And also fix some comments as suggested by lcnr

lcnr · 2020-08-13T08:55:01Z

@bors r+

bors · 2020-08-13T08:55:03Z

📌 Commit 5c0b416 has been approved by lcnr

bors · 2020-08-13T10:32:03Z

⌛ Testing commit 5c0b416 with merge 1a7d9f5...

bors · 2020-08-13T12:43:06Z

☀️ Test successful - checks-actions, checks-azure
Approved by: lcnr
Pushing 1a7d9f5 to master...

rust-highfive assigned lcnr Aug 9, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2020

lcnr reviewed Aug 9, 2020

View reviewed changes

src/test/ui/const-generics/uninferred-consts.rs Outdated Show resolved Hide resolved

JulianKnodt force-pushed the revisions branch from 1c1e402 to bced1ed Compare August 9, 2020 06:25

lcnr reviewed Aug 9, 2020

View reviewed changes

src/test/ui/const-generics/unknown_adt.rs Outdated Show resolved Hide resolved

JulianKnodt force-pushed the revisions branch 2 times, most recently from d2fe81d to 0f14e6b Compare August 9, 2020 21:23

lcnr reviewed Aug 10, 2020

View reviewed changes

src/test/ui/const-generics/condition-in-trait-const-arg.rs Outdated Show resolved Hide resolved

lcnr approved these changes Aug 10, 2020

View reviewed changes

JulianKnodt force-pushed the revisions branch from dc3dc28 to bd376dd Compare August 11, 2020 00:06

JulianKnodt force-pushed the revisions branch 2 times, most recently from e344a5c to ca6e996 Compare August 11, 2020 04:30

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2020

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 11, 2020

JulianKnodt force-pushed the revisions branch from ca6e996 to c3a23fb Compare August 11, 2020 22:30

JulianKnodt added 2 commits August 12, 2020 08:30

Add a bunch of revisions

be650a7

This adds a bunch of revisions to const-generic tests

Add missing tests in root const-gen dir

9bf40f1

JulianKnodt force-pushed the revisions branch from c3a23fb to 9130d1e Compare August 12, 2020 08:31

Update stderr files

5c0b416

And also fix some comments as suggested by lcnr

JulianKnodt force-pushed the revisions branch from 9130d1e to 5c0b416 Compare August 12, 2020 20:04

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2020

bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 13, 2020

bors merged commit 1a7d9f5 into rust-lang:master Aug 13, 2020

This was referenced Aug 13, 2020

diagnostics: shorten paths of unique symbols #73996

Merged

move const param structural match checks to wfcheck #75069

Merged

lcnr added the F-const_generics `#![feature(const_generics)]` label Nov 14, 2020

lcnr mentioned this pull request Nov 17, 2020

Tracking issue for const generics (RFC 2000) #44580

Closed

16 tasks

cuviper added this to the 1.47.0 milestone May 2, 2024

Add a bunch of const-generic revisions for min_const_generics #75322

Add a bunch of const-generic revisions for min_const_generics #75322

Uh oh!

Conversation

JulianKnodt commented Aug 9, 2020

Uh oh!

Uh oh!

Uh oh!

lcnr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Aug 11, 2020

Uh oh!

lcnr commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

bors commented Aug 11, 2020

Uh oh!

bors commented Aug 11, 2020

Uh oh!

bors commented Aug 11, 2020

Uh oh!

lcnr commented Aug 11, 2020

Uh oh!

bors commented Aug 11, 2020

Uh oh!

lcnr commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bors commented Aug 11, 2020

Uh oh!

bors commented Aug 11, 2020

Uh oh!

lcnr commented Aug 11, 2020

Uh oh!

lcnr commented Aug 13, 2020

Uh oh!

bors commented Aug 13, 2020

Uh oh!

bors commented Aug 13, 2020

Uh oh!

bors commented Aug 13, 2020

Uh oh!

Uh oh!

Add a bunch of const-generic revisions for `min_const_generics` #75322

Add a bunch of const-generic revisions for `min_const_generics` #75322

lcnr commented Aug 11, 2020 •

edited

Loading

lcnr commented Aug 11, 2020 •

edited

Loading