fix rustdoc generic param order #74992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
lcnr
commented
Jul 31, 2020
Comment on lines
-122
to
-129
| for param in &mut params { | ||
| match param.kind { | ||
| clean::GenericParamDefKind::Type { ref mut bounds, .. } => { | ||
| *bounds = mem::take(bounds); | ||
| } | ||
| _ => panic!("expected only type parameters"), | ||
| } | ||
| } |
There was a problem hiding this comment.
Am I missing something here?
|
Looks good to me! It even simplifies the code so that's great. 👍 @bors: r+ |
|
📌 Commit b90bc8d has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b90bc8d with merge 5720e5675920c1f6ca4664c8f13ce75af150bcab... |
ollie27
added
the
T-rustdoc
|
Hmm, surprised that CI builds are taking three hours again |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
Let's see if this was spurious I guess @bors r=GuillaumeGomez |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit b90bc8d has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 2, 2020
…arth Rollup of 5 pull requests Successful merges: - rust-lang#74602 (Clarify the doc for MaybeUninit::zeroed on incorrect use) - rust-lang#74720 (Clean up E0728 explanation) - rust-lang#74992 (fix rustdoc generic param order) - rust-lang#75015 (Add Vec::spare_capacity_mut) - rust-lang#75022 (Use a slice pattern instead of rchunks_exact(_).next()) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #61292
r? @varkor cc @GuillaumeGomez