Set shell for github actions CI #74406

Mark-Simulacrum · 2020-07-16T17:50:27Z

r? @pietroalbini but because this seems at worst harmless and CI is broken self approving

Mark-Simulacrum · 2020-07-16T17:50:45Z

@bors r+ p=10

bors · 2020-07-16T17:50:46Z

📌 Commit fe95f0ee97c05b1283f6cdd912cb4f3516df9efd has been approved by Mark-Simulacrum

bors · 2020-07-16T17:50:47Z

🌲 The tree is currently closed for pull requests below priority 5, this pull request will be tested once the tree is reopened

bors · 2020-07-16T17:50:59Z

⌛ Testing commit fe95f0ee97c05b1283f6cdd912cb4f3516df9efd with merge fff7504ab0a9536ed0bb475a6937c5efda8e1103...

Mark-Simulacrum · 2020-07-16T17:52:01Z

@bors r-

Hm okay so need to do it manually seems like

The workflow is not valid. .github/workflows/ci.yml (Line: 67, Col: 9): Unexpected value 'shell',.github/workflows/ci.yml (Line: 187, Col: 9): Unexpected value 'shell'

Mark-Simulacrum · 2020-07-16T17:55:30Z

@bors r+ p=10

Seems to at least validate as a valid config now

bors · 2020-07-16T17:55:31Z

📌 Commit 5b287f6 has been approved by Mark-Simulacrum

bors · 2020-07-16T17:55:42Z

⌛ Testing commit 5b287f6 with merge f6b3fa041883c254704f35d850c93dd8aa1c72d4...

rye

One note: you can use defaults.run to specify the default for all run steps in a job instead of specifying manually for each run step, like:

defaults:
  run:
    shell: bash

@pietroalbini

…r=Mark-Simulacrum Set shell for github actions CI r? @pietroalbini but because this seems at worst harmless and CI is broken self approving

Manishearth · 2020-07-16T18:01:10Z

@bors p=4 retry yield

Including in rollup

Mark-Simulacrum · 2020-07-16T18:03:03Z

One note: you can use defaults.run to specify the default for all run steps in a job instead of specifying manually for each run step, like:
defaults:
  run:
    shell: bash

This sounds great -- but let's get CI unblocked first. I personally am a bit scared of changing defaults in a self-approved PR like this as well

rye · 2020-07-16T18:11:49Z

This sounds great -- but let's get CI unblocked first.

No problem, I can submit a follow-up PR once the queue cools off a bit.

@ghost

…arth Rollup of 21 pull requests Successful merges: - rust-lang#73566 (Don't run `everybody_loops` for rustdoc; instead ignore resolution errors) - rust-lang#73771 (Don't pollute docs/suggestions with libstd deps) - rust-lang#73794 (Small cleanup for E0705 explanation) - rust-lang#73807 (rustdoc: glue tokens before highlighting) - rust-lang#73835 (Clean up E0710 explanation) - rust-lang#73926 (Ignoring test case: [codegen] repr-transparent-aggregates-1.rs for aarch64) - rust-lang#73981 (Remove some `ignore-stage1` annotations.) - rust-lang#73998 (add regression test for rust-lang#61216) - rust-lang#74140 (Make hir ProjectionKind more precise) - rust-lang#74148 (Move #[doc(alias)] check in rustc) - rust-lang#74159 (forbid generic params in the type of const params) - rust-lang#74171 (Fix 44056 test with debug on macos.) - rust-lang#74221 (Don't panic if the lhs of a div by zero is not statically known) - rust-lang#74325 (Focus on the current file in the source file sidebar) - rust-lang#74359 (rustdoc: Rename internal API fns to `into_string`) - rust-lang#74370 (Reintroduce spotlight / "important traits" feature) - rust-lang#74390 (Fix typo in std::mem::transmute documentation) - rust-lang#74391 (BtreeMap: superficially refactor root access) - rust-lang#74392 (const generics triage) - rust-lang#74397 (Fix typo in the latest release note) - rust-lang#74406 (Set shell for github actions CI) Failed merges: r? @ghost

A follow-up to rust-lang#74406, this commit merely removes the `shell: bash` lines where they are explicitly added in favor of setting defaults for *all* "run" steps. Signed-off-by: Kristofer Rye <[email protected]>

@Mark-Simulacrum

…roalbini ci: Set `shell: bash` as a default, remove duplicates A follow-up to rust-lang#74406, this commit merely removes the `shell: bash` lines where they were added in favor of setting defaults for *all* "run" steps in the jobs that run the tests. The changes in rust-lang#74406 were needed because of an upstream change to the `windows-2019` GitHub Actions image. Previously, the configuration worked fine without specifying `shell: bash`, but for some reason this broke with a new change that was deployed today. The preceding PR was a hotfix to get CI passing, but there was a slightly less duplicative way to specify the default shell for the jobs, which was to set the `defaults.run` option. This change applies to the `pr`, `try`, `auto`, and `auto-fallible` jobs, which are derived from the YAML-anchor `base-ci-job`. I did not apply these changes to the `master`, `try-success`, `try-failure`, `auto-success`, or `auto-failure` jobs because they have only a few steps. cc/r? @Mark-Simulacrum

@Mark-Simulacrum

…roalbini ci: Set `shell: bash` as a default, remove duplicates A follow-up to rust-lang#74406, this commit merely removes the `shell: bash` lines where they were added in favor of setting defaults for *all* "run" steps in the jobs that run the tests. The changes in rust-lang#74406 were needed because of an upstream change to the `windows-2019` GitHub Actions image. Previously, the configuration worked fine without specifying `shell: bash`, but for some reason this broke with a new change that was deployed today. The preceding PR was a hotfix to get CI passing, but there was a slightly less duplicative way to specify the default shell for the jobs, which was to set the `defaults.run` option. This change applies to the `pr`, `try`, `auto`, and `auto-fallible` jobs, which are derived from the YAML-anchor `base-ci-job`. I did not apply these changes to the `master`, `try-success`, `try-failure`, `auto-success`, or `auto-failure` jobs because they have only a few steps. cc/r? @Mark-Simulacrum

@Mark-Simulacrum

…roalbini ci: Set `shell: bash` as a default, remove duplicates A follow-up to rust-lang#74406, this commit merely removes the `shell: bash` lines where they were added in favor of setting defaults for *all* "run" steps in the jobs that run the tests. The changes in rust-lang#74406 were needed because of an upstream change to the `windows-2019` GitHub Actions image. Previously, the configuration worked fine without specifying `shell: bash`, but for some reason this broke with a new change that was deployed today. The preceding PR was a hotfix to get CI passing, but there was a slightly less duplicative way to specify the default shell for the jobs, which was to set the `defaults.run` option. This change applies to the `pr`, `try`, `auto`, and `auto-fallible` jobs, which are derived from the YAML-anchor `base-ci-job`. I did not apply these changes to the `master`, `try-success`, `try-failure`, `auto-success`, or `auto-failure` jobs because they have only a few steps. cc/r? @Mark-Simulacrum

@pietroalbini

…r=Mark-Simulacrum Set shell for github actions CI r? @pietroalbini but because this seems at worst harmless and CI is broken self approving

@Mark-Simulacrum

…roalbini ci: Set `shell: bash` as a default, remove duplicates A follow-up to rust-lang#74406, this commit merely removes the `shell: bash` lines where they were added in favor of setting defaults for *all* "run" steps in the jobs that run the tests. The changes in rust-lang#74406 were needed because of an upstream change to the `windows-2019` GitHub Actions image. Previously, the configuration worked fine without specifying `shell: bash`, but for some reason this broke with a new change that was deployed today. The preceding PR was a hotfix to get CI passing, but there was a slightly less duplicative way to specify the default shell for the jobs, which was to set the `defaults.run` option. This change applies to the `pr`, `try`, `auto`, and `auto-fallible` jobs, which are derived from the YAML-anchor `base-ci-job`. I did not apply these changes to the `master`, `try-success`, `try-failure`, `auto-success`, or `auto-failure` jobs because they have only a few steps. cc/r? @Mark-Simulacrum

A follow-up to rust-lang#74406, this commit merely removes the `shell: bash` lines where they are explicitly added in favor of setting defaults for *all* "run" steps. Signed-off-by: Kristofer Rye <[email protected]>

rust-highfive assigned pietroalbini Jul 16, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 16, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2020

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 16, 2020

Set shell for github actions CI

5b287f6

Mark-Simulacrum force-pushed the fix-windows-maybe branch from fe95f0e to 5b287f6 Compare July 16, 2020 17:53

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 16, 2020

rye reviewed Jul 16, 2020

View reviewed changes

Manishearth mentioned this pull request Jul 16, 2020

Rollup of 17 pull requests #74407

Closed

Manishearth mentioned this pull request Jul 16, 2020

Add WSL actions/runner-images#1081

Merged

2 tasks

Manishearth mentioned this pull request Jul 16, 2020

Rollup of 21 pull requests #74408

Merged

bors merged commit ff685f5 into rust-lang:master Jul 16, 2020

rye mentioned this pull request Jul 16, 2020

ci: Set shell: bash as a default, remove duplicates #74418

Merged

ehuss mentioned this pull request Jul 22, 2020

[beta] Update cargo #74593

Merged

ehuss mentioned this pull request Jul 23, 2020

[stable] 1.45.1 release #74574

Merged

cuviper added this to the 1.47.0 milestone May 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Set shell for github actions CI #74406

Set shell for github actions CI #74406

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

rye left a comment •

edited

Loading

Uh oh!

Manishearth commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

rye commented Jul 16, 2020

Uh oh!

Uh oh!

Set shell for github actions CI #74406

Set shell for github actions CI #74406

Uh oh!

Conversation

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

bors commented Jul 16, 2020

Uh oh!

rye left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Manishearth commented Jul 16, 2020

Uh oh!

Mark-Simulacrum commented Jul 16, 2020

Uh oh!

rye commented Jul 16, 2020

Uh oh!

Uh oh!

rye left a comment •

edited

Loading