Whitelist #[allow_internal_unstable] #72713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should hopefully work around #65023, which currently makes almost every bootstrap fail for me.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Gah. Would be great to fix these lints to work properly. Approving since it seems like a low-loss and quite harmful to productivity change. @bors r+ |
|
📌 Commit d4ef174 has been approved by |
bors
added
S-waiting-on-bors
Aaron1011
reviewed
May 29, 2020
| @@ -366,7 +366,7 @@ pub const BUILTIN_ATTRIBUTES: &[BuiltinAttribute] = &[ | |||
| // FIXME(#14407) | |||
| ungated!(rustc_const_stable, Whitelisted, template!(List: r#"feature = "name""#)), | |||
| gated!( | |||
| allow_internal_unstable, Normal, template!(Word, List: "feat1, feat2, ..."), | |||
| allow_internal_unstable, Whitelisted, template!(Word, List: "feat1, feat2, ..."), | |||
There was a problem hiding this comment.
It might be a good idea to add a FIXME mentioning that this should eventually be changed back to Normal.
There was a problem hiding this comment.
I think in the long term Whitelisted should just not exist, right? But r=me with such a comment too.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 29, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#71633 (Impl Error for Infallible) - rust-lang#71843 (Tweak and stabilize AtomicN::fetch_update) - rust-lang#72288 (Stabilization of weak-into-raw) - rust-lang#72324 (Stabilize AtomicN::fetch_min and AtomicN::fetch_max) - rust-lang#72452 (Clarified the documentation for Formatter::precision) - rust-lang#72495 (Improve E0601 explanation) - rust-lang#72534 (Improve missing `@` in slice binding pattern diagnostics) - rust-lang#72547 (Added a codegen test for a recent optimization for overflow-checks=on) - rust-lang#72711 (remove redundant `mk_const`) - rust-lang#72713 (Whitelist #[allow_internal_unstable]) - rust-lang#72720 (Clarify the documentation of `take`) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully work around #65023, which currently makes almost every bootstrap fail for me.