- 
                Notifications
    
You must be signed in to change notification settings  - Fork 13.9k
 
          borrowck DefId -> LocalDefId
          #72103
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
  
    borrowck DefId -> LocalDefId
  
  #72103
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           r? @estebank (rust_highfive has picked a reviewer for you, use r? to override)  | 
    
| 
           @estebank Do you have the time to review this or should I try and assign it to someone else?  | 
    
| 
           @bors r+  | 
    
| 
           📌 Commit 3f661d2 has been approved by   | 
    
| 
           ⌛ Testing commit 3f661d2 with merge e6e710ff632645704628aaca2478ed6717408637...  | 
    
| 
           @bors retry yield  | 
    
| 
           @lcnr was just about to review but @jonas-schievink got to it faster :)  | 
    
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      May 29, 2020 
    
    
      
  
    
      
    
  
…chievink borrowck `DefId` -> `LocalDefId` Replaces some `DefId`s which must always be local with `LocalDefId` in `librustc_mir/borrowck`. cc @marmeladema
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      May 29, 2020 
    
    
      
  
    
      
    
  
…chievink borrowck `DefId` -> `LocalDefId` Replaces some `DefId`s which must always be local with `LocalDefId` in `librustc_mir/borrowck`. cc @marmeladema
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      May 29, 2020 
    
    
      
  
    
      
    
  
…chievink borrowck `DefId` -> `LocalDefId` Replaces some `DefId`s which must always be local with `LocalDefId` in `librustc_mir/borrowck`. cc @marmeladema
    
  RalfJung 
      added a commit
        to RalfJung/rust
      that referenced
      this pull request
    
      May 29, 2020 
    
    
      
  
    
      
    
  
…chievink borrowck `DefId` -> `LocalDefId` Replaces some `DefId`s which must always be local with `LocalDefId` in `librustc_mir/borrowck`. cc @marmeladema
    
  bors 
      added a commit
        to rust-lang-ci/rust
      that referenced
      this pull request
    
      May 29, 2020 
    
    
      
  
    
      
    
  
Rollup of 9 pull requests Successful merges: - rust-lang#67460 (Tweak impl signature mismatch errors involving `RegionKind::ReVar` lifetimes) - rust-lang#71095 (impl From<[T; N]> for Box<[T]>) - rust-lang#71500 (Make pointer offset methods/intrinsics const) - rust-lang#71804 (linker: Support `-static-pie` and `-static -shared`) - rust-lang#71862 (Implement RFC 2585: unsafe blocks in unsafe fn) - rust-lang#72103 (borrowck `DefId` -> `LocalDefId`) - rust-lang#72407 (Various minor improvements to Ipv6Addr::Display) - rust-lang#72413 (impl Step for char (make Range*<char> iterable)) - rust-lang#72439 (NVPTX support for new asm!) Failed merges: r? @ghost
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    S-waiting-on-bors
  Status: Waiting on bors to run and complete tests. Bors will change the label on completion. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Replaces some
DefIds which must always be local withLocalDefIdinlibrustc_mir/borrowck.cc @marmeladema