Rollup of 5 pull requests #71992
Merged
Rollup of 5 pull requests #71992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… r=Mark-Simulacrum
Add Arc::{incr,decr}_strong_count
This adds two `unsafe` methods to `Arc`: `incr_strong_count` and `decr_strong_count`. A suggestion to add methods to change the strong count in `Arc` came up in during review in rust-lang#68700 (comment), and from asking a few people this seemed like generally useful to have.
References:
- [Motivation from rust-lang#68700](rust-lang#68700 (comment))
- [Real world example in an executor](https://docs.rs/extreme/666.666.666666/src/extreme/lib.rs.html#13)
…ulacrum improve Drop documentation Fixes rust-lang#36073 This is a continuation of rust-lang#57449 and most of the work here was done by the excellent @steveklabnik.
Detect errors caused by `async` block in 2015 edition Fix rust-lang#67204.
…trochenkov reword "possible candidate" import suggestion This suggestion has always read a bit awkwardly to me, particularly the "possible better candidate" variant. This commit rewords the suggestion to be more concise and mention the kind of the suggested item. There isn't a nice way to label individual suggestions, so I opted to use "items" in the case of multiple suggestions.
Fix E0284 to not use incorrect wording Fix rust-lang#71584, fix rust-lang#69683.
|
@bors r+ p=5 rollup=never |
|
📌 Commit 14cbbf3 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors r- one pr failed, couldn't find a better timing xD |
bors
added
S-waiting-on-author
|
meh spurious |
|
@bors r+ |
|
📌 Commit 14cbbf3 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 14cbbf3 with merge e41c21efc2289c0dffcb09e86fce37ba32d3401c... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry p=1000 |
bors
removed
the
S-waiting-on-review
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 14cbbf3 with merge 520240b61952c0b44dd748b644d2269002c82b3a... |
|
yielding to gha fix @bors retry |
|
⌛ Testing commit 14cbbf3 with merge ed15e8a68f24f995e799862dc9230f03430acd6b... |
|
@bors retry |
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
asyncblock in 2015 edition #71783 (Detect errors caused byasyncblock in 2015 edition)Failed merges:
r? @ghost