Moving more build-pass tests to check-pass #71340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Valloric
force-pushed
the
more-check-pass
branch
from
4296771 to
160f4ae
Compare
|
The mingw-check timed out and appears to be a flake; not sure how to trigger a re-run... |
One or two tests became build-pass without the FIXME because they really needed build-pass (were failing without it). Helps with rust-lang#62277
Valloric
force-pushed
the
more-check-pass
branch
from
160f4ae to
2155adb
Compare
|
📌 Commit 2155adb has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71340 (Moving more build-pass tests to check-pass) - rust-lang#71456 (Use lib crate type for SGX in `fn build_auxiliary`) - rust-lang#71615 (share some common code for compile-time miri instances) - rust-lang#71637 (Minor formatting changes in `cfg-sanitize.md`) - rust-lang#71641 (Update books) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One or two tests became build-pass without the FIXME because they really
needed build-pass (were failing without it).
Helps with #62277
This change is