Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Mar 10, 2020

Successful merges:

Failed merges:

r? @ghost

GuillaumeGomez and others added 30 commits February 27, 2020 14:51
Adds borrowck tests for the following features:
- bindings_after_at
- or_patterns
- slice_patterns
- box_patterns
dylnuge and others added 12 commits March 9, 2020 12:31
Remove the `no_force` query attribute

This removes the `no_force` query attribute and instead uses the `DepNodeParams` trait to find out if a query can be forced.

Also the `analysis` query is moved to the query macro.

r? @eddyb
…kinnison

Remove spotlight

I had a few comments saying that this feature was at best misunderstood or not even used so I decided to organize a poll about on [twitter](https://twitter.com/imperioworld_/status/1232769353503956994). After 87 votes, the result is very clear: it's not useful. Considering the amount of code we have just to run it, I think it's definitely worth it to remove it.

r? @kinnison

cc @ollie27
rustc_metadata: Give decoder access to whole crate store

Pre-requisite for rust-lang#68941.
r? @eddyb
…i-obk

Make PlaceRef take just one lifetime

r? @eddyb
Allow ZSTs in `AllocRef`

Allows ZSTs in all `AllocRef` methods. The implementation of `AllocRef` for `Global` and `System` were adjusted to reflect those changes.

This is the second item on the roadmap to support ZSTs in `AllocRef`: rust-lang/wg-allocators#38 (comment)
After this has landed, I will adapt `RawVec`, but since this will be a pretty big overhaul, it makes sense to do a different PR for it.

~~Requires rust-lang#69794 to land first~~

r? @Amanieu
…n-features, r=Centril

test(patterns): add patterns feature tests to borrowck test suite

Addresses request here: rust-lang#69690 (comment)

Fixes rust-lang#67311.

r? @Centril
…Simulacrum

Add note about localization to std::fmt docs

Closes rust-lang#69681
Vec::new is const stable in 1.39 not 1.32

Changelog: https://github.com/rust-lang/rust/blob/master/RELEASES.md#version-1390-2019-11-07

This really surprised me when a MSRV check for 1.35 failed with `Vec::new is not yet stable as a const fn` and the docs said that it was const stabilized in 1.32.
@Centril
Copy link
Contributor Author

Centril commented Mar 10, 2020

@bors r+ p=1001 rollup=never

@bors
Copy link
Collaborator

bors commented Mar 10, 2020

📌 Commit 3e9efbd has been approved by Centril

@bors
Copy link
Collaborator

bors commented Mar 10, 2020

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 10, 2020
@Centril Centril added the rollup A PR which is a rollup label Mar 10, 2020
@bors
Copy link
Collaborator

bors commented Mar 10, 2020

⌛ Testing commit 3e9efbd with merge dd155df...

@bors
Copy link
Collaborator

bors commented Mar 10, 2020

☀️ Test successful - checks-azure
Approved by: Centril
Pushing dd155df to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.