Rollup of 6 pull requests #69440
Merged
Rollup of 6 pull requests #69440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le_book, r=nikomatsakis Add documentation for the `-Zself-profile` flag
…crum Add rustdoc aliases to `ptr::copy` and `ptr::copy_nonoverlapping` This PR adds a [rustdoc alias](https://doc.rust-lang.org/nightly/rustdoc/unstable-features.html#add-aliases-for-an-item-in-documentation-search) to `ptr::copy` and `ptr::copy_nonoverlapping` using the commonly used terms `memcpy` and `memmove`. The motivation for this PR is to improve discoverability for these functions, since I've noticed users overlook these functions on multiple occasions (and they have thus reached for [libc](https://crates.io/crates/libc) without need). Currently std docs state: https://doc.rust-lang.org/nightly/std/ptr/fn.copy_nonoverlapping.html > `copy_nonoverlapping` is semantically equivalent to C's `memcpy`, but with the argument order swapped. https://doc.rust-lang.org/nightly/std/ptr/fn.copy.html > `copy` is semantically equivalent to C's `memmove`, but with the argument order swapped. #### search results before adding a rustdoc alias:   #### after adding `#[doc(alias = "memcpy")]` and `#[doc(alias = "memmove")]`:  
… r=Dylan-DPC Cleanup e0368 e0369 r? @Dylan-DPC
don't explicitly compare against true or false
Replace uses of Cell::get + Cell::set with Cell::replace.
…c-morse no more codegen for miri_start_panic With rust-lang/miri#1136 landed, we don't generate code any more for crates that will be run by Miri. So the LLVM backend does not have to implement the `miri_start_panic` intrinsic any more. Cc @Aaron1011
|
@bors r+ rollup=never p=6 |
|
📌 Commit e238eb6 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit e238eb6 with merge 541650abffc588bebe6496d2fefbf11143b8115d... |
|
@bors retry yielding to stable PR |
|
@bors treeclosed- |
|
⌛ Testing commit e238eb6 with merge b7544f3b1e35d7b51eabadb97dc959ab7d02e581... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 25, 2020
Tested on commit rust-lang/rust@e3a2779. Direct link to PR: <rust-lang/rust#69440> 💔 miri on windows: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung). 💔 miri on linux: test-pass → test-fail (cc @oli-obk @eddyb @RalfJung).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
-Zself-profileflag #69220 (Add documentation for the-Zself-profileflag)ptr::copyandptr::copy_nonoverlapping#69391 (Add rustdoc aliases toptr::copyandptr::copy_nonoverlapping)Failed merges:
r? @ghost