Skip to content

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Feb 16, 2020

Allow whitespaces in revision flags, like // [foo].

Fixes #69183

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+

This can be rolled up if CI passes, but it seems not impossible that it'll pick up a new revision somewhere so it might fail.

@bors
Copy link
Collaborator

bors commented Feb 16, 2020

📌 Commit d1a7ae7 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2020
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 16, 2020
…-Simulacrum

Allow whitespaces in revision flags

Allow whitespaces in revision flags, like `// [foo]`.

Fixes rust-lang#69183
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 18, 2020
…-Simulacrum

Allow whitespaces in revision flags

Allow whitespaces in revision flags, like `// [foo]`.

Fixes rust-lang#69183
bors added a commit that referenced this pull request Feb 18, 2020
Rollup of 5 pull requests

Successful merges:

 - #69181 (Change const eval to just return the value )
 - #69192 (Add more regression tests)
 - #69200 (Fix printing of `Yield` terminator)
 - #69205 (Allow whitespaces in revision flags)
 - #69233 (Clean up E0310 explanation)

Failed merges:

r? @ghost
@bors bors merged commit d1a7ae7 into rust-lang:master Feb 18, 2020
@JohnTitor JohnTitor deleted the allow-whitespaces branch February 18, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compiletest: revision-dependent compile-flags are space-sensitive
4 participants