Skip to content

Transition macro_legacy_warnings into a hard error #69129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2020
Merged

Transition macro_legacy_warnings into a hard error #69129

merged 1 commit into from
Feb 17, 2020

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Feb 13, 2020

Fixes #67098.

r? @petrochenkov

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 13, 2020
@Centril
Copy link
Contributor Author

Centril commented Feb 13, 2020

@bors try

@bors
Copy link
Collaborator

bors commented Feb 13, 2020

⌛ Trying commit cec2a9f with merge c846f8a7dc7af09647f397f047db9cc81acb60bd...

@Centril Centril added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2020
@bors
Copy link
Collaborator

bors commented Feb 13, 2020

☀️ Try build successful - checks-azure
Build commit: c846f8a7dc7af09647f397f047db9cc81acb60bd (c846f8a7dc7af09647f397f047db9cc81acb60bd)

@Centril
Copy link
Contributor Author

Centril commented Feb 13, 2020

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-69129 created and queued.
🤖 Automatically detected try build c846f8a7dc7af09647f397f047db9cc81acb60bd
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🚧 Experiment pr-69129 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-69129 is completed!
📊 2 regressed and 1 fixed (90999 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Feb 17, 2020
This was referenced Feb 17, 2020
Closed
Merged
Merged
@Centril
Copy link
Contributor Author

Centril commented Feb 17, 2020

Filed PRs against the 2 non-crates.io regressions. This should be ready to go now.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 17, 2020

📌 Commit cec2a9f has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 17, 2020
@bors
Copy link
Collaborator

bors commented Feb 17, 2020

⌛ Testing commit cec2a9f with merge 2983a558155a5887a10bc021d4aea2e9a5ad75dd...

Centril added a commit to Centril/rust that referenced this pull request Feb 17, 2020
@Centril
Rollup merge of rust-lang#69129 - Centril:macro-legacy-errors, r=petr…
3122c80 
…ochenkov

Transition macro_legacy_warnings into a hard error

Fixes rust-lang#67098.

r? @petrochenkov
@Centril Centril mentioned this pull request Feb 17, 2020
Closed
@Centril
Copy link
Contributor Author

Centril commented Feb 17, 2020

@bors retry

@bors
Copy link
Collaborator

bors commented Feb 17, 2020

⌛ Testing commit cec2a9f with merge 0176a9e...

bors added a commit that referenced this pull request Feb 17, 2020
@bors
Auto merge of #69129 - Centril:macro-legacy-errors, r=petrochenkov
0176a9e 
Transition macro_legacy_warnings into a hard error

Fixes #67098.

r? @petrochenkov
@bors
Copy link
Collaborator

bors commented Feb 17, 2020

☀️ Test successful - checks-azure
Approved by: petrochenkov
Pushing 0176a9e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 17, 2020
@bors bors merged commit cec2a9f into rust-lang:master Feb 17, 2020
@Centril Centril deleted the macro-legacy-errors branch February 17, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Turn macro_legacy_warnings into a hard error
5 participants
@Centril @bors @craterbot @petrochenkov @rust-highfive