Rollup of 11 pull requests #68587
Merged
Rollup of 11 pull requests #68587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Dylan DPC <[email protected]>
…ue, r=alexcrichton Stabilize the debug_map_key_value feature RFC: rust-lang/rfcs#2696 Tracking issue: rust-lang#62482 Stabilizes the `debug_map_key_value` feature, which covers: ```rust impl<'a, 'b> DebugMap<'a, 'b> { pub fn key(&mut self, key: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {} pub fn value(&mut self, value: &dyn fmt::Debug) -> &mut DebugMap<'a, 'b> {} } ``` These methods are small and self-contained, and are used as the basis for the existing `DebugMap::entry` method, so have been used in the wild for the last 6 months or so.
…lan-DPC Clean up E0205 explanation r? @Dylan-DPC
…lan-DPC Clean up E0207 explanation r? @Dylan-DPC
…lan-DPC clean up E0214 explanation r? @Dylan-DPC
…r=Dylan-DPC clean up error codes explanation r? @Dylan-DPC
Don't call `tcx.fn_sig` on closures Fixes rust-lang#68542
…chton Bump LLVM submodule to fix LLVM assertion failure in MSP430 interrupt generation. This PR brings in changes introduced by [this cherry-pick](rust-lang/llvm-project#37) to the Rust repository. Nightlies downloaded from `rustup` do not appear to have llvm assertions enabled; the assertion failure [sometimes](YuhanLiin/msp430fr2355-quickstart#3) causes link errors that shouldn't occur. I couldn't find any indication of other bugs; however, it should still be fixed.
check_match: extract common logic This is part of work on `hir::ExprKind::Let` which I thought made sense on its own (though makes even more sense with `::Let`). r? @oli-obk
…lan-DPC Clean up E0262 explanation r? @Dylan-DPC
Disable the testcase for Vxworks. r? @alexcrichton
…nup-crew, r=Dylan-DPC Add support for icebreakers-cleanup-crew commands r? @nikomatsakis
|
@bors r+ p=11 rollup=never |
|
📌 Commit aac5788 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 28, 2020
Rollup of 11 pull requests Successful merges: - #68200 (Stabilize the debug_map_key_value feature) - #68383 (Clean up E0205 explanation) - #68412 (Clean up E0207 explanation) - #68454 (clean up E0214 explanation) - #68482 (clean up error codes explanation) - #68563 (Don't call `tcx.fn_sig` on closures) - #68570 (Bump LLVM submodule to fix LLVM assertion failure in MSP430 interrupt generation.) - #68571 (check_match: extract common logic) - #68573 (Clean up E0262 explanation) - #68575 (Disable the testcase for Vxworks.) - #68581 (Add support for icebreakers-cleanup-crew commands) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
tcx.fn_sigon closures #68563 (Don't calltcx.fn_sigon closures)Failed merges:
r? @ghost