Speed up optimization pipeline #6828
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why this is failing... one more try. |
|
The failures here are scary. Is LLVM miscompiling something? |
bors
added a commit
that referenced
this pull request
May 31, 2013
A workaround to get #6828 through.
|
Landed the first commit in #6859. I don't know why the others are failing (I tried without SROA). |
|
I have a far better pipeline in a new branch. Once I make sure it doesn't end up with the same issue, I'll open a new PR. |
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 25, 2021
…convention, r=flip1995 wrong_self_convention: fix lint in case of `to_*_mut` method fixes rust-lang#6758 changelog: wrong_self_convention: fix lint in case of `to_*_mut` method. When a method starts with `to_` and ends with `_mut`, clippy expects a `&mut self` parameter, otherwise `&self`. Any feedback is welcome. I was also thinking if shouldn't we treat `to_` the same way as `as_`. Namely to accept `self` taken: `&self` or `&mut self`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This alters the pipeline to improve the speed of the passes without impacting the performance of the compiled code.
This also makes
mergefunca default pass as it actually improves the speed of the inliner (less to inline) and lowers the size of the compiled binary, without a noticeable change in performance.