rustc: Switch ty::node_type_table to smallintmap, cut 400mb memory use off a librustc build. #6776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e off a librustc build. Smallintmap was being populated with sparse keys during ast deserialization.
|
Out of curiosity, do you know if this hits perf at all? That was the only thing stopping me from doing this when I saw it. Also, yay! |
|
The measurements I took show it running slightly faster. Though they were not the most precise, might conflate factors. |
bors
added a commit
that referenced
this pull request
May 28, 2013
Smallintmap was being populated with sparse keys during ast deserialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smallintmap was being populated with sparse keys during ast deserialization.