Skip to content

Conversation

flip1995
Copy link
Member

@rust-highfive
Copy link
Contributor

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 23, 2019
@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 23, 2019

📌 Commit 450880f has been approved by Manishearth

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 23, 2019
@Manishearth
Copy link
Member

@bors p=3

@bors
Copy link
Collaborator

bors commented Nov 23, 2019

⌛ Testing commit 450880f with merge 0c987c5...

bors added a commit that referenced this pull request Nov 23, 2019
@bors
Copy link
Collaborator

bors commented Nov 23, 2019

☀️ Test successful - checks-azure
Approved by: Manishearth
Pushing 0c987c5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 23, 2019
@bors bors merged commit 450880f into rust-lang:master Nov 23, 2019
@rust-highfive
Copy link
Contributor

📣 Toolstate changed by #66674!

Tested on commit 0c987c5.
Direct link to PR: #66674

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Nov 23, 2019
Tested on commit rust-lang/rust@0c987c5.
Direct link to PR: <rust-lang/rust#66674>

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
@tmandry
Copy link
Member

tmandry commented Nov 26, 2019

process nit, please link to the issue (e.g. #66486) closed by PRs like this.

@flip1995 flip1995 deleted the clippyup branch November 27, 2019 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants