Don't assert for different instance on impl trait alias #65753
Merged
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
Adding the two tests from the issue would be good. :) |
mati865
reviewed
Oct 24, 2019
Centril
reviewed
Oct 24, 2019
Centril
reviewed
Oct 24, 2019
src/test/ui/type-alias-impl-trait/issue-65679-inst-opaque-ty-from-val-twice.rs
Outdated
Show resolved
Hide resolved
src/test/ui/type-alias-impl-trait/issue-65679-inst-opaque-ty-from-val-twice.rs
Outdated
Show resolved
Hide resolved
|
r=@Centril |
|
@bors r+ rollup |
|
📌 Commit ab8c4d3c9845011b50726161ba9fb81ebf901694 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
|
r=@Centril (sorry for tidy error) |
|
@bors r+ rollup |
|
📌 Commit 184a61f has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 24, 2019
Don't assert for different instance on impl trait alias Closes rust-lang#65679 r? @Centril @nikomatsakis
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 24, 2019
Don't assert for different instance on impl trait alias Closes rust-lang#65679 r? @Centril @nikomatsakis
bors
added a commit
that referenced
this pull request
Oct 25, 2019
Rollup of 8 pull requests Successful merges: - #65625 (Turn crate store into a resolver output) - #65627 (Forbid non-`structural_match` types in const generics) - #65710 (Update cargo) - #65729 (Update test cases for vxWorks) - #65746 (Tweak format string error to point at arguments always) - #65753 (Don't assert for different instance on impl trait alias) - #65755 (Avoid ICE when adjusting bad self ty) - #65766 (Update hashbrown to 0.6.2) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #65679
r? @Centril @nikomatsakis