Skip to content

Deprecated proc_macro doesn't trigger warning on build library #65666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2019
Merged

Deprecated proc_macro doesn't trigger warning on build library #65666

merged 3 commits into from
Oct 25, 2019

Conversation

XiangQingW
Copy link
Contributor

Fix #65189

@XiangQingW
Deprecated proc_macro doesn't trigger warning on build library
33910f9 
Change-Id: Ib3a396e7334d209fe6c6ef425bbfc7b2ae471378
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2019
@XiangQingW XiangQingW mentioned this pull request Oct 21, 2019
Closed
@XiangQingW
Copy link
Contributor Author

r? @petrochenkov

Centril
Centril reviewed Oct 21, 2019
View reviewed changes
@Centril

This comment has been minimized.

Sign in to view
petrochenkov
petrochenkov reviewed Oct 21, 2019
View reviewed changes
@petrochenkov
Copy link
Contributor

Some minor comments.

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2019
@XiangQingW
Deprecated proc_macro doesn't trigger warning on build library
c027be0 
Change-Id: Ib3a396e7334d209fe6c6ef425bbfc7b2ae471378
@XiangQingW
Copy link
Contributor Author

@petrochenkov @Centril Tanks for your help. I amend the pr. Would you mind reviewing it again if you have free time?

@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Collaborator

bors commented Oct 22, 2019

📌 Commit c027be0 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 22, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 23, 2019
@Centril
Rollup merge of rust-lang#65666 - XiangQingW:proc_macro, r=petrochenkov
cea5879 
Deprecated proc_macro doesn't trigger warning on build library

Fix rust-lang#65189
@Centril Centril mentioned this pull request Oct 23, 2019
Closed
@Centril
Copy link
Contributor

Centril commented Oct 23, 2019

Failed in #65723 (comment), @bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2019
@petrochenkov
Copy link
Contributor

petrochenkov commented Oct 24, 2019 •
edited
Loading

#65484 (comment) said to copy the file rather than create it from scratch because the obscure header

// force-host
// no-prefer-dynamic

is important for cross-compilation.
It should be kept.

@XiangQingW
Deprecated proc_macro doesn't trigger warning on build library
b133156 
Change-Id: Ib3a396e7334d209fe6c6ef425bbfc7b2ae471378
@XiangQingW
Copy link
Contributor Author

XiangQingW commented Oct 24, 2019 •
edited
Loading

#65484 (comment) said to copy the file rather than create it from scratch because the obscure header

// force-host
// no-prefer-dynamic

is important for cross-compilation.
It should be kept.

Thanks.
Could you please review again? It's important, however, I can't find the document introducing it.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 24, 2019

📌 Commit b133156 has been approved by petrochenkov

@bors
Copy link
Collaborator

bors commented Oct 24, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
@Centril
Rollup merge of rust-lang#65666 - XiangQingW:proc_macro, r=petrochenkov
fb602c7 
Deprecated proc_macro doesn't trigger warning on build library

Fix rust-lang#65189
@Centril Centril mentioned this pull request Oct 25, 2019
Merged
bors added a commit that referenced this pull request Oct 25, 2019
@bors
Auto merge of #65793 - Centril:rollup-v40xke9, r=Centril
dd2df8f 
Rollup of 9 pull requests

Successful merges:

 - #62959 (Add by-value iterator for arrays )
 - #65390 (Add long error explanation for E0576)
 - #65408 (reorder config.toml.example options and add one missing option)
 - #65414 (ignore uninhabited non-exhaustive variant fields)
 - #65666 (Deprecated proc_macro doesn't trigger warning on build library)
 - #65742 (Pre-expansion gate most of the things)
 - #65747 (Adjust the tracking issue for `untagged_unions`.)
 - #65763 (Changed APIT with explicit generic args span to specific arg spans)
 - #65775 (Fix more `ReEmpty` ICEs)

Failed merges:

 - #65519 (trait-based structural match implementation)

r? @ghost
@bors bors merged commit b133156 into rust-lang:master Oct 25, 2019
@taiki-e taiki-e mentioned this pull request Jun 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

+1 more reviewer

@Centril Centril Centril left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecated proc_macro trigger warning on build library
6 participants
@XiangQingW @rust-highfive @Centril @petrochenkov @bors @alexcrichton