Support "soft" feature-gating using a lint #64066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Sep 1, 2019
matthewjasper
added
the
beta-nominated
|
r=me with @Centril's comment addressed |
Centril
added
the
T-compiler
nikomatsakis
added
the
beta-accepted
matthewjasper
added
S-waiting-on-author
Use it for feature-gating `#[bench]`
petrochenkov
force-pushed
the
softstab
branch
from
f06029d to
74d8679
Compare
|
@bors r=matthewjasper |
|
📌 Commit 74d8679 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 7, 2019
Support "soft" feature-gating using a lint Use it for feature-gating `#[bench]`. Closes rust-lang#63798.
bors
added a commit
that referenced
this pull request
Sep 7, 2019
Rollup of 5 pull requests Successful merges: - #64052 (Rename test locals to work around LLDB bug) - #64066 (Support "soft" feature-gating using a lint) - #64177 (resolve: Do not afraid to set current module to enums and traits) - #64229 (Reduce span to function name in unreachable calls) - #64255 (Add methods for converting `bool` to `Option<T>`) Failed merges: r? @ghost
bors
added a commit
that referenced
this pull request
Sep 14, 2019
[beta] Rollup backports Cherry-picked: - Permit unwinding through FFI by default #62603 - pprust: Do not print spaces before some tokens #63897 - Account for doc comments coming from proc macros without spans #63930 - Support "soft" feature-gating using a lint #64066 - Update xLTO compatibility table in rustc book. #64092 - Include compiler-rt in the source tarball #64240 - Update LLVM submodule #64317 r? @Mark-Simulacrum
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
de-stabilize bench attribute This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274). The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it. Cc `@rust-lang/libs-api`
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
May 7, 2025
…aheemdev,traviscross de-stabilize bench attribute This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274). The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it. Cc `@rust-lang/libs-api`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 7, 2025
Rollup merge of rust-lang#134273 - RalfJung:de-stabilize-bench, r=ibraheemdev,traviscross de-stabilize bench attribute This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274). The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it. Cc `@rust-lang/libs-api`
github-actions bot
pushed a commit
to carolynzech/rust
that referenced
this pull request
May 16, 2025
…aheemdev,traviscross de-stabilize bench attribute This has been soft-unstable since forever (rust-lang#64066), and shown in future-compat reports since Rust 1.77 (rust-lang#116274). The feature covering `bench` itself is tracked in rust-lang#50297, which has been closed despite still having active feature gates referencing it. Cc `@rust-lang/libs-api`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use it for feature-gating
#[bench].Closes #63798.