Remove some uses of mem::uninitialized #62422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
tesuji
changed the title
RalfJung
reviewed
Jul 5, 2019
| srWindow: [libc::c_short; 4], | ||
| dwMaximumWindowSize: [libc::c_short; 2], | ||
| srWindow: SMALL_RECT, | ||
| dwMaximumWindowSize: COORD, |
There was a problem hiding this comment.
What is all of this diff about?
There was a problem hiding this comment.
Just to make CONSOLE_SCREEN_BUFFER_INFO definition like the one in winapi.
There was a problem hiding this comment.
I don't think I can review Windows FFI code I am afraid. I can't even remember how big a DWORD is.
|
r? @alexcrichton |
|
@bors: r+ |
|
📌 Commit 6ca83c6d793e3336ae99087242c84153069c37e6 has been approved by |
bors
added
S-waiting-on-bors
tesuji
force-pushed
the
remove-some-mem-uinit
branch
from
6ca83c6 to
7646d49
Compare
|
Rebased to tidy history. |
|
@bors r=alexcrichton |
|
📌 Commit 7646d49 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…xcrichton Remove some uses of mem::uninitialized cc rust-lang#62397 r? @RalfJung
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
Rollup of 4 pull requests [1] Successful merges: - rust-lang#62243 (Improve documentation for built-in macros) - rust-lang#62422 (Remove some uses of mem::uninitialized) - rust-lang#62432 (Update rustfmt to 1.3.2) - rust-lang#62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…xcrichton Remove some uses of mem::uninitialized cc rust-lang#62397 r? @RalfJung
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…xcrichton Remove some uses of mem::uninitialized cc rust-lang#62397 r? @RalfJung
bors
added a commit
that referenced
this pull request
Jul 6, 2019
Rollup of 6 pull requests Successful merges: - #60081 (Refactor unicode.py script) - #61862 (Make the Weak::{into,as}_raw methods) - #62243 (Improve documentation for built-in macros) - #62422 (Remove some uses of mem::uninitialized) - #62432 (Update rustfmt to 1.3.2) - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…xcrichton Remove some uses of mem::uninitialized cc rust-lang#62397 r? @RalfJung
bors
added a commit
that referenced
this pull request
Jul 6, 2019
Rollup of 5 pull requests Successful merges: - #60081 (Refactor unicode.py script) - #61862 (Make the Weak::{into,as}_raw methods) - #62243 (Improve documentation for built-in macros) - #62422 (Remove some uses of mem::uninitialized) - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #62397
r? @RalfJung