Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 22, 2019

Successful merges:

Failed merges:

r? @ghost

Centril and others added 11 commits June 22, 2019 12:11
It's in the documentation of `Unsize`.
The errors are either:
- The meta-variable used in the right-hand side is not bound (or defined) in the
  left-hand side.
- The meta-variable used in the right-hand side does not repeat with the same
  kleene operator as its binder in the left-hand side. Either it does not repeat
  enough, or it uses a different operator somewhere.

This change should have no semantic impact.
…bank

Trigger `unused_attribute` lint on `#[cfg_attr($pred,)]`

Lint on `#[cfg_attr($pred,)]` as decided in rust-lang#54881 (comment).

Closes rust-lang#54881.

r? @estebank
Fix one missing `dyn`.

It's in the documentation of `Unsize`.
…ives, r=Mark-Simulacrum

Deny explicit_outlives_requirements in the compiler
Fix meta-variable binding errors in macros

The errors are either:
- The meta-variable used in the right-hand side is not bound (or defined) in the
  left-hand side.
- The meta-variable used in the right-hand side does not repeat with the same
  kleene operator as its binder in the left-hand side. Either it does not repeat
  enough, or it uses a different operator somewhere.

This change should have no semantic impact.

Found by rust-lang#62008
@Centril
Copy link
Contributor Author

Centril commented Jun 22, 2019

@bors r+ p=5 rollup=never

@bors
Copy link
Collaborator

bors commented Jun 22, 2019

📌 Commit 74380b3 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 22, 2019
@bors
Copy link
Collaborator

bors commented Jun 23, 2019

⌛ Testing commit 74380b3 with merge a96ba96...

bors added a commit that referenced this pull request Jun 23, 2019
Rollup of 5 pull requests

Successful merges:

 - #62047 (Trigger `unused_attribute` lint on `#[cfg_attr($pred,)]`)
 - #62049 (Fix one missing `dyn`.)
 - #62051 (Lint empty `#[derive()]` as unused attribute.)
 - #62057 (Deny explicit_outlives_requirements in the compiler)
 - #62068 (Fix meta-variable binding errors in macros)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Jun 23, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing a96ba96 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 23, 2019
@bors bors merged commit 74380b3 into rust-lang:master Jun 23, 2019
@Centril Centril deleted the rollup-m8n4uw7 branch June 23, 2019 03:13
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants