Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 2, 2019

Successful merges:

Failed merges:

r? @ghost

varkor and others added 20 commits May 31, 2019 01:19
This changes a mistake introduced in rust-lang#61195 where the mangling
workaround used was incorrect.
A semicolon is missing in the examples of compile_error.
Macros that expand to items must be delimited with braces or followed by a semicolon.
…eddyb

Fix some issues with `unwrap_usize` instead of `assert_usize`

Fixes rust-lang#61337.
Fixes rust-lang#61341.
Fixes rust-lang#61422.

r? @eddyb
…r=eddyb

codegen: change `$6d$` to `$u6d$`

This changes a mistake introduced in rust-lang#61195 where the mangling
workaround used was incorrect, resolving [this comment](rust-lang#61195 (comment)) from @eddyb.

r? @eddyb
Point at individual type args on arg count mismatch

- Point at individual type arguments on arg count mismatch
- Make generics always have a valid span, even when there are no args
- Explain that `impl Trait` introduces an implicit type argument

Fix rust-lang#55991.
Tweak wording when encountering `fn` call in pattern

Fix rust-lang#60642
Fix missing semicolon in doc

A semicolon is missing in the examples of compile_error.
Macros that expand to items must be delimited with braces or followed by a semicolon.
@Centril
Copy link
Contributor Author

Centril commented Jun 2, 2019

@bors r+ p=6 rollup=never

@bors
Copy link
Collaborator

bors commented Jun 2, 2019

📌 Commit aaf264b has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 2, 2019
@bors
Copy link
Collaborator

bors commented Jun 2, 2019

⌛ Testing commit aaf264b with merge d461555...

bors added a commit that referenced this pull request Jun 2, 2019
Rollup of 6 pull requests

Successful merges:

 - #61380 (Fix some issues with `unwrap_usize` instead of `assert_usize`)
 - #61423 (codegen: change `$6d$` to `$u6d$`)
 - #61438 (Point at individual type args on arg count mismatch)
 - #61441 (Tweak wording when encountering `fn` call in pattern)
 - #61451 (Fix missing semicolon in doc)
 - #61458 (Fix typo in AsRef doc)

Failed merges:

r? @ghost
@bors
Copy link
Collaborator

bors commented Jun 2, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing d461555 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 2, 2019
@bors bors merged commit aaf264b into rust-lang:master Jun 2, 2019
@Centril Centril deleted the rollup-8txhjx4 branch June 2, 2019 17:58
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants