Move match_path from DefId to lint::LateContext #59738
Merged
+114
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
LGTM. r? @oli-obk or @Manishearth for where exactly to put it (I assume there may be more helper methods like this?) |
|
@bors r=eddyb,Manishearth |
|
📌 Commit 278ab19 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 278ab19 with merge 6b53b03a880f31ba2202e505c7391d7094e30cf6... |
|
⌛ Testing commit 278ab19 with merge 7d7bf303d280dabf2f65a1e535ae0759c6d0c4ac... |
|
@bors retry |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 6, 2019
…anishearth Move match_path from DefId to lint::LateContext cc rust-lang#59316 (comment) r? @eddyb
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 6, 2019
…anishearth Move match_path from DefId to lint::LateContext cc rust-lang#59316 (comment) r? @eddyb
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 8, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Apr 11, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 15, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #59316 (comment)
r? @eddyb