Skip to content

Conversation

@c410-f3r
Copy link
Contributor

Related #154 and #1320.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2019
@Centril Centril added T-lang Relevant to the language team T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. labels Mar 10, 2019
@petrochenkov
Copy link
Contributor

No PartialEq/Eq for Ident and Span please, they cause bugs.
See, for example, #58942 as the most recent instance.
Some explicit way to compare only span locations or only Ident's string representations would be ok, I guess.

Punct also contains a span, so comparisons are at least questionable, and most likely wrong if they are derived.

@petrochenkov
Copy link
Contributor

cc #51074

@c410-f3r
Copy link
Contributor Author

Thanks for the explanation @petrochenkov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-lang Relevant to the language team T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants