Skip to content

rustc-workspace-hack => 2018 #58288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 12, 2019
Merged

rustc-workspace-hack => 2018 #58288

merged 1 commit into from
Feb 12, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Feb 8, 2019

Transitions rustc-workspace-hack to Rust 2018; cc #58099

r? @alexcrichton

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 8, 2019
@taiki-e
Copy link
Member Author

taiki-e commented Feb 8, 2019

I think that #![deny(rust_2018_idioms)] is unnecessary because lib.rs is blank and it has a comment "intentionally left blank".

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Feb 11, 2019

📌 Commit 36806b5 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2019
@alexcrichton
Copy link
Member

@bors: rollup

@Centril Centril mentioned this pull request Feb 11, 2019
Closed
78 tasks
Centril added a commit to Centril/rust that referenced this pull request Feb 12, 2019
@Centril
Rollup merge of rust-lang#58288 - taiki-e:rustc-workspace-hack-2018, …
b8fe6f9 
…r=alexcrichton

rustc-workspace-hack => 2018

Transitions `rustc-workspace-hack` to Rust 2018; cc rust-lang#58099

r? @alexcrichton
@Centril Centril mentioned this pull request Feb 12, 2019
Merged
bors added a commit that referenced this pull request Feb 12, 2019
@bors
Auto merge of #58389 - Centril:rollup, r=Centril
75f9159 
Rollup of 11 pull requests

Successful merges:

 - #58105 (libarena => 2018)
 - #58111 (libterm => 2018)
 - #58287 (rustc-std-workspace-core => 2018)
 - #58288 (rustc-workspace-hack => 2018)
 - #58300 (librustc_typeck => 2018)
 - #58313 (Use `?` in librustc macros)
 - #58318 (libserialize => 2018)
 - #58322 (librustc_codegen_ssa => 2018)
 - #58342 (Revert removed #![feature(nll)])
 - #58367 (Remove two dead functions.)
 - #58382 (docs: remove "experimental" wording from std::os::unix)

Failed merges:

r? @ghost
@bors bors merged commit 36806b5 into rust-lang:master Feb 12, 2019
@taiki-e taiki-e deleted the rustc-workspace-hack-2018 branch February 12, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taiki-e @alexcrichton @bors @rust-highfive