Skip to content

Conversation

h-michael
Copy link
Contributor

@h-michael h-michael commented Feb 3, 2019

Transition src/tools/linkchecker to Rust 2018.

#58099

@rust-highfive

This comment has been minimized.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 3, 2019
@Centril
Copy link
Contributor

Centril commented Feb 3, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned nikomatsakis Feb 3, 2019
@Centril
Copy link
Contributor

Centril commented Feb 3, 2019

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 3, 2019

📌 Commit 3a133f2 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 3, 2019
@bors
Copy link
Collaborator

bors commented Feb 4, 2019

⌛ Testing commit 3a133f2 with merge d925c71678fddad7ac0030accd977c652df0371b...

@bors
Copy link
Collaborator

bors commented Feb 4, 2019

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 4, 2019
@kennytm
Copy link
Member

kennytm commented Feb 4, 2019

@bors retry

Command exited with code 259

and also the build has run for 3 hr 39 min 🤔

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 4, 2019
kennytm added a commit to kennytm/rust that referenced this pull request Feb 5, 2019
Transition linkchecker to 2018 edition

Transition `src/tools/linkchecker` to Rust 2018.

rust-lang#58099
bors added a commit that referenced this pull request Feb 5, 2019
Rollup of 23 pull requests

Successful merges:

 - #58001 (proc_macro: make `TokenStream::from_streams` pre-allocate its vector.)
 - #58096 (Transition linkchecker to 2018 edition)
 - #58097 (Transition remote test to Rust 2018)
 - #58106 (libfmt_macros => 2018)
 - #58107 (libgraphviz => 2018)
 - #58108 (Add NVPTX target to a build manifest)
 - #58109 (librustc_privacy => 2018)
 - #58112 (libpanic_abort => 2018)
 - #58113 (Transition build-manifest to 2018 edition)
 - #58114 (Transition tidy and unstable-book-gen to 2018 edition)
 - #58116 (Include the span of attributes of the lhs to the span of the assignment expression)
 - #58117 (Transition rustdoc-theme to 2018 edition)
 - #58128 (libunwind => 2018)
 - #58138 (Fix #58101)
 - #58139 (hir: add more HirId methods)
 - #58141 (Remove weasel word in docs for iter's take_while())
 - #58142 (Remove stray FIXME)
 - #58145 (Add #[must_use] to core::task::Poll)
 - #58162 (Add more debugging code to track down appveyor 259 exit code)
 - #58169 (Update contributor name in .mailmap)
 - #58172 (update split docs)
 - #58182 (SGX target: handle empty user buffers correctly)
 - #58186 (Add Rustlings to the doc index)

Failed merges:

r? @ghost
@bors bors merged commit 3a133f2 into rust-lang:master Feb 5, 2019
@h-michael h-michael deleted the linkchecker-2018 branch February 6, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants