Skip to content

Conversation

pepyakin
Copy link
Contributor

Revert of #53237
As per discussion here rustwasm/team#251

@rust-highfive
Copy link
Contributor

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2019
@pepyakin
Copy link
Contributor Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

cc @overdrivenpotato

@bors
Copy link
Collaborator

bors commented Jan 23, 2019

📌 Commit 0db2587 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Jan 23, 2019

🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2019
Centril added a commit to Centril/rust that referenced this pull request Jan 24, 2019
…alexcrichton

Don't export table by default in wasm

Revert of rust-lang#53237
As per discussion here rustwasm/team#251
Centril added a commit to Centril/rust that referenced this pull request Jan 24, 2019
…alexcrichton

Don't export table by default in wasm

Revert of rust-lang#53237
As per discussion here rustwasm/team#251
bors added a commit that referenced this pull request Jan 24, 2019
Rollup of 9 pull requests

Successful merges:

 - #57380 (Fix Instant/Duration math precision & associativity on Windows)
 - #57606 (Get rid of the fake stack frame for reading from constants)
 - #57803 (Several changes to libunwind for SGX target)
 - #57846 (rustdoc: fix ICE from loading proc-macro stubs)
 - #57860 (Add os::fortanix_sgx::ffi module)
 - #57861 (Don't export table by default in wasm)
 - #57863 (Add suggestion for incorrect field syntax.)
 - #57867 (Fix std::future::from_generator documentation)
 - #57873 (Stabilize no_panic_pow)

Failed merges:

r? @ghost
@bors bors merged commit 0db2587 into rust-lang:master Jan 25, 2019
@pepyakin pepyakin deleted the wasm-dont-export-table branch January 28, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants