Reborrow Pin<P> using &mut in Pin::set
#57419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to call `.set` multiple times without using `.as_mut()` first to reborrow the pointer.
rust-highfive
added
the
S-waiting-on-review
|
@bors r=me This needs to be backported to beta, I'm not sure about the procedure here. |
|
@bors: r=withouboats |
|
📌 Commit 68e98a2 has been approved by |
bors
added
S-waiting-on-bors
alexcrichton
added
beta-nominated
|
@bors r=withoutboats |
|
@bors p=1 Giving prio to make sure this lands since it's beta-nominated/accepted and beta=>stable happens soon. |
bors
added a commit
that referenced
this pull request
Jan 9, 2019
Reborrow Pin<P> using &mut in `Pin::set` Fixes #57339. This makes it possible to call `.set` multiple times without using `.as_mut()` first to reborrow the pointer. r? @withoutboats cc @rust-lang/libs
|
☀️ Test successful - status-appveyor, status-travis |
Centril
removed
beta-accepted
|
I think there was some confusion here.. |
|
Oops my bad, can confirm nothing needed for a backport! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57339.
This makes it possible to call
.setmultiple times withoutusing
.as_mut()first to reborrow the pointer.r? @withoutboats
cc @rust-lang/libs